all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "J.P." <jp@neverwas.me>
To: 70840-done@debbugs.gnu.org
Cc: Thibaut Meyer <thibaut@thibaut.dev>, emacs-erc@gnu.org
Subject: bug#70840: 29.3; ERC 5.5.0.29.1: erc-kill-buffer-on-part kills server buffer
Date: Tue, 28 May 2024 06:36:36 -0700	[thread overview]
Message-ID: <87wmnenjmj.fsf__14962.0971105591$1716903443$gmane$org@neverwas.me> (raw)
In-Reply-To: <87wmnt5bun.fsf@neverwas.me> (J. P.'s message of "Thu, 16 May 2024 20:57:52 -0700")

"J.P." <jp@neverwas.me> writes:

> After thinking a bit more on this, I've flip-flopped entirely on the
> notion of running `erc-part-hook' in `erc-kill-channel' and inhibiting
> it in `erc-server-PART' with a would-be null buffer argument. Basically,
> I've come to believe the current faulty behavior has been around too
> long to justify such a change in the name of fixing a bug that's only
> tangentially related. Instead, I think we should introduce a flag that
> `erc-kill-channel-hook' members can use to detect when `erc-server-PART'
> is killing a buffer on behalf of the option `erc-kill-buffer-on-part'.
> Updated patch attached. Thanks.

I've installed something similar as

  cf7cc4c630a Don't kill server buffer with erc-kill-buffer-on-part

Thanks and closing.





      parent reply	other threads:[~2024-05-28 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08 20:37 bug#70840: 29.3; ERC 5.5.0.29.1: erc-kill-buffer-on-part kills server buffer Thibaut Meyer via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14  0:55 ` J.P.
     [not found] ` <8734ql9ppd.fsf@neverwas.me>
2024-05-15 13:22   ` J.P.
     [not found]   ` <87seyj6wgh.fsf@neverwas.me>
2024-05-17  3:57     ` J.P.
     [not found]     ` <87wmnt5bun.fsf@neverwas.me>
2024-05-28 13:36       ` J.P. [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87wmnenjmj.fsf__14962.0971105591$1716903443$gmane$org@neverwas.me' \
    --to=jp@neverwas.me \
    --cc=70840-done@debbugs.gnu.org \
    --cc=emacs-erc@gnu.org \
    --cc=thibaut@thibaut.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.