From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions Date: Sun, 02 Jun 2024 13:11:38 +0000 Message-ID: <87wmn7ebg5.fsf@posteo.net> References: <87edcrtegz.fsf@gmail.com> <87sf15rjyf.fsf@gmail.com> <8734t5yh49.fsf@posteo.net> <87edcp9p54.fsf@breatheoutbreathe.in> <878qzypbav.fsf@posteo.net> <86ed9qyxnm.fsf@gnu.org> <871q5ffvs9.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10527"; mail-complaints-to="usenet@ciao.gmane.io" Cc: iarchivedmywholelife@gmail.com, joseph@breatheoutbreathe.in, 69528@debbugs.gnu.org, Eli Zaretskii , Andrea Corallo , Stefan Monnier To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 02 15:13:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sDl1J-0002WN-D9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jun 2024 15:13:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sDl13-0002nl-KE; Sun, 02 Jun 2024 09:12:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDl11-0002nK-BS for bug-gnu-emacs@gnu.org; Sun, 02 Jun 2024 09:12:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDl10-0001Gd-TL for bug-gnu-emacs@gnu.org; Sun, 02 Jun 2024 09:12:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sDl1C-0003Sa-GV for bug-gnu-emacs@gnu.org; Sun, 02 Jun 2024 09:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jun 2024 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69528 X-GNU-PR-Package: emacs Original-Received: via spool by 69528-submit@debbugs.gnu.org id=B69528.171733392213220 (code B ref 69528); Sun, 02 Jun 2024 13:13:02 +0000 Original-Received: (at 69528) by debbugs.gnu.org; 2 Jun 2024 13:12:02 +0000 Original-Received: from localhost ([127.0.0.1]:58038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDl0E-0003R3-0X for submit@debbugs.gnu.org; Sun, 02 Jun 2024 09:12:02 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:35329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDl09-0003Ql-SP for 69528@debbugs.gnu.org; Sun, 02 Jun 2024 09:12:00 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CDD11240027 for <69528@debbugs.gnu.org>; Sun, 2 Jun 2024 15:11:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1717333899; bh=olbPms2RRXEC51RXSWenG5lD/l4SVI9lYl12naFuyA4=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=DVOfh0FqcLWG5xl78V/1rNiSIah8qAdyFtLB9XhaAzBrR8x9YWwyNJYETclnsGQmq giUVtJ2DWsWGbJd6f8kfmfFXwYP/U/kPkfDFE5UHxpN70RAzk2G/C4M2YZprNHMj2f Vj42ubb6NXbgWc7ir7ZA4esaTEzBcDNEm4Xt+l3jO8why0hCqG7GdnwWsfgG3vYDSf UxGIBl1kV5xL8FPsjtPNoIegj7Vt84TQXEHAGTAHJ5AjR9HCVPqzB2zR4xuPJnSBZ4 EG6VA9EVGc21s7wEGiuMXmD9lX6/cnM/ElFZKNBnxdfW/KhG7Eo+QDhUUvrmnwfZL8 gQchz2gXxGfpg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Vscgv02Vlz9rxD; Sun, 2 Jun 2024 15:11:38 +0200 (CEST) In-Reply-To: (Stefan Kangas's message of "Sun, 2 Jun 2024 05:08:58 -0700") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286388 Archived-At: Stefan Kangas writes: > Philip Kaludercic writes: > >>> 2. The way I read the manual, it seems like "Package-Version" should be >>> preferred over "Version", if it exists: >>> >>> =E2=80=98Package-Version=E2=80=99 >>> If =E2=80=98Version=E2=80=99 is not suitable for use by th= e package manager, then a >>> package can define =E2=80=98Package-Version=E2=80=99; it w= ill be used instead. >>> This is handy if =E2=80=98Version=E2=80=99 is an RCS id or= something else that >>> cannot be parsed by =E2=80=98version-to-list=E2=80=99. >> >> FWIW I use this for some of my own scripts that I version using RCS, so >> I'd appreciate it if that functionality would stay. > > OK, so let's keep it. But shouldn't the below be the correct order > according to the above quoted documentation? > > diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el > index f111a77663c..5db0b50adc3 100644 > --- a/lisp/emacs-lisp/lisp-mnt.el > +++ b/lisp/emacs-lisp/lisp-mnt.el > @@ -415,7 +415,8 @@ lm-version > "Return the version listed in file FILE, or current buffer if FILE is = nil. > This can be found in an RCS or SCCS header." > (lm-with-file file > - (or (lm-header "version") > + (or (lm-header "package-version") > + (lm-header "version") > (let ((header-max (lm-code-start))) > (goto-char (point-min)) > (cond Of course, that was also the change proposed in my first patch but I didn't notice the change in Joseph's suggestion. --=20 Philip Kaludercic on peregrine