all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Philip Kaludercic <philipk@posteo.net>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: iarchivedmywholelife@gmail.com, joseph@breatheoutbreathe.in,
	69528@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
	Andrea Corallo <acorallo@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Date: Sun, 02 Jun 2024 13:11:38 +0000	[thread overview]
Message-ID: <87wmn7ebg5.fsf@posteo.net> (raw)
In-Reply-To: <CADwFkmkw4s_LUK83o1HJPDNESRtocUVYcZ8SXtCJKx_AMZuN_Q@mail.gmail.com> (Stefan Kangas's message of "Sun, 2 Jun 2024 05:08:58 -0700")

Stefan Kangas <stefankangas@gmail.com> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>>> 2. The way I read the manual, it seems like "Package-Version" should be
>>>    preferred over "Version", if it exists:
>>>
>>>         ‘Package-Version’
>>>              If ‘Version’ is not suitable for use by the package manager, then a
>>>              package can define ‘Package-Version’; it will be used instead.
>>>              This is handy if ‘Version’ is an RCS id or something else that
>>>              cannot be parsed by ‘version-to-list’.
>>
>> FWIW I use this for some of my own scripts that I version using RCS, so
>> I'd appreciate it if that functionality would stay.
>
> OK, so let's keep it.  But shouldn't the below be the correct order
> according to the above quoted documentation?
>
> diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el
> index f111a77663c..5db0b50adc3 100644
> --- a/lisp/emacs-lisp/lisp-mnt.el
> +++ b/lisp/emacs-lisp/lisp-mnt.el
> @@ -415,7 +415,8 @@ lm-version
>    "Return the version listed in file FILE, or current buffer if FILE is nil.
>  This can be found in an RCS or SCCS header."
>    (lm-with-file file
> -    (or (lm-header "version")
> +    (or (lm-header "package-version")
> +        (lm-header "version")
>          (let ((header-max (lm-code-start)))
>  	  (goto-char (point-min))
>  	  (cond

Of course, that was also the change proposed in my first patch but I
didn't notice the change in Joseph's suggestion.

-- 
	Philip Kaludercic on peregrine





  reply	other threads:[~2024-06-02 13:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-03 17:25 bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions No Wayman
2024-03-04 17:22 ` No Wayman
2024-03-04 18:41   ` Philip Kaludercic
2024-03-05  6:17     ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-09  6:53       ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25  7:39         ` Eli Zaretskii
2024-05-25  8:04       ` Philip Kaludercic
2024-05-25  8:08         ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25  8:47           ` Philip Kaludercic
2024-05-26  0:45             ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 10:49         ` Eli Zaretskii
2024-06-02 10:36           ` Stefan Kangas
2024-06-02 11:07             ` Philip Kaludercic
2024-06-02 12:08               ` Stefan Kangas
2024-06-02 13:11                 ` Philip Kaludercic [this message]
2024-06-02 18:26                   ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 18:40                     ` Philip Kaludercic
2024-06-03 17:24                     ` Stefan Kangas
2024-06-03 19:24                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-03 19:58                         ` Philip Kaludercic
2024-06-03 20:38                           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 22:19                             ` Stefan Kangas
2024-06-04 22:34                               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 22:22                       ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmn7ebg5.fsf@posteo.net \
    --to=philipk@posteo.net \
    --cc=69528@debbugs.gnu.org \
    --cc=acorallo@gnu.org \
    --cc=eliz@gnu.org \
    --cc=iarchivedmywholelife@gmail.com \
    --cc=joseph@breatheoutbreathe.in \
    --cc=monnier@iro.umontreal.ca \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.