From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Michael Heerdegen via "Emacs development discussions." <emacs-devel@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Dired delete(d) the wrong file!
Date: Sat, 06 Jul 2024 01:28:37 +0200
Message-ID: <87wmlza062.fsf@web.de>
References: <CAOCW0DjZkpQK=6QbwEgSaM0sPDziwdnk9T6HLm+=OipEiDud1g@mail.gmail.com>
 <s54jzi0iqav.fsf@yahoo.com> <86r0c875s4.fsf@gnu.org>
 <CAOCW0Djg83m5LESyvqGo5TgVvYGx=0v64XLgfZhc=LEOdROhtA@mail.gmail.com>
 <86h6d470oh.fsf@gnu.org>
Reply-To: Michael Heerdegen <michael_heerdegen@web.de>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="14279"; mail-complaints-to="usenet@ciao.gmane.io"
User-Agent: Gnus/5.13 (Gnus v5.13)
To: emacs-devel@gnu.org
Cancel-Lock: sha1:4qnBNp8HroozquruexRmf/mblgc=
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 06 01:28:45 2024
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1sPsM8-0003Uk-W1
	for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jul 2024 01:28:44 +0200
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1sPsLO-00028o-MQ; Fri, 05 Jul 2024 19:27:58 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ged-emacs-devel@m.gmane-mx.org>)
 id 1sPsLM-00028A-Rx
 for emacs-devel@gnu.org; Fri, 05 Jul 2024 19:27:56 -0400
Original-Received: from ciao.gmane.io ([116.202.254.214])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ged-emacs-devel@m.gmane-mx.org>)
 id 1sPsLL-00048o-53
 for emacs-devel@gnu.org; Fri, 05 Jul 2024 19:27:56 -0400
Original-Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <ged-emacs-devel@m.gmane-mx.org>) id 1sPsLI-0002Qa-Hu
 for emacs-devel@gnu.org; Sat, 06 Jul 2024 01:27:52 +0200
X-Injected-Via-Gmane: http://gmane.org/
Received-SPF: pass client-ip=116.202.254.214;
 envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9,
 FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001,
 HEADER_FROM_DIFFERENT_DOMAINS=0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:321399
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/321399>

Eli Zaretskii <eliz@gnu.org> writes:

> diff --git a/lisp/files.el b/lisp/files.el
> index 042b8e2..c518273 100644
> --- a/lisp/files.el
> +++ b/lisp/files.el
> @@ -8087,8 +8087,8 @@ insert-directory-clean
>  		  (end (insert-directory-adj-pos
>  			(+ beg (read (current-buffer)))
>  			error-lines)))
> -	      (if (memq (char-after end) '(?\n ?\s))
> -		  ;; End is followed by \n or by " -> ".
> +	      (if (memq (char-after end) '(?\n ?\s ?/ ?* ?@ ?% ?= ?|))
> +		  ;; End is followed by \n or by output of -F.

How about emitting a warning message when this condition fails?  It
could help us to detect other problematic cases and warn users that
Dired needs to fall back to a heuristical parsing of ls output.


Michael.