From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Willcock Newsgroups: gmane.emacs.devel Subject: Accidental change of behaviour for electric-layout-mode? Date: Mon, 23 Sep 2024 21:58:13 +0100 Message-ID: <87wmj2dr4q.fsf@ice9.digital> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25270"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 23 22:59:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ssq9R-0006SZ-O9 for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Sep 2024 22:59:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssq8Y-0002jz-Ns; Mon, 23 Sep 2024 16:58:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssq8W-0002jU-Jf for emacs-devel@gnu.org; Mon, 23 Sep 2024 16:58:24 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssq8T-0002rj-On for emacs-devel@gnu.org; Mon, 23 Sep 2024 16:58:24 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id EF9E0E0004 for ; Mon, 23 Sep 2024 20:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1727125094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=atmA8KkoGdUTEY4Z8s3n6Qve7+oD5kOEW4YpLd6tEg4=; b=Trl46Vp4bnAIXvadg4D0zPABk2CdPZ7XjGMyObDCU+6qg1gZVEUeVjDqXiyG6tTlJfzna9 tie82SaRsIf+QNfyjEPt/7wL64cMj/rhNYGqwqJmBjKxsDA7UaDlKRL+9VS7amKz6nd01E EQPnDZjfEkodlFYE/RpOYhmJ/sGoUzUHx9iIy5RyDkwA4sXK/eHlyqyoyqRFPZ3fLgvzWS ziJ1zfs1MR+2LCCBkPpwxoHOfJQdPLdwWKC1C7U0XviCLfU68EKolgpq5XiMLrGqYXPguh coM8o9UMwHX9y1pfERKGhj+s70iZbivEQejSBR+EfAIhthWFVI19CkRX7pAqmw== X-GND-Sasl: morgan@ice9.digital Received-SPF: pass client-ip=217.70.183.196; envelope-from=morgan@ice9.digital; helo=relay4-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323999 Archived-At: It looks like Emacs 30 is now allowing electric-layout-mode to insert newlines inside comments and strings, whereas previous versions seem to explicitly stop this from happening. The commit that does it is b1f8d98a119ab8845d25d80c480cde6e385d8749 (Eglot: rework eglot-imenu) which doesn't mention electric-layout-mode in the commit message or the associated bug report (58431). I think it may have been done accidentally and is likely not a backwards compatible change. (I actually wanted the new behaviour and only found this because my tests for newline insertion failed on Emacs 27, 28, and 29. Making the new behaviour opt-in would be nice, so I could send a patch to do that if the previous change does look to have been accidental.) Morgan -- Morgan Willcock