From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#74104: 31.0.50; 'custom-set-faces' overrides face when no theme is loaded Date: Thu, 31 Oct 2024 07:35:34 +0200 Message-ID: <87wmhozvfd.fsf@protesilaos.com> References: <87y125ucbz.fsf@protesilaos.com> <86plnh4n2l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7627"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74104@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 31 06:37:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t6Ns6-0001nE-1L for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Oct 2024 06:37:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6Nrw-0000wW-KK; Thu, 31 Oct 2024 01:37:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6Nri-0000ql-Ki for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 01:37:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6Nri-00056m-CT for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 01:37:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=l5q2BIpF0gZnzRqf/1mqAQ+Ra6qv9WP40V08GpTWWeU=; b=u8XxgFAPYs1eZnQb+no1faTxlGq/AH4qJrHDgRFuW1oEXfMUJJbAwX2WeDK1yja0aabV7VIM8LHLe4JOq1j2jNUkp0nl8tZ85JRCnFrZsunEfIYUuSF2FGmPEdoX7+janlcbaroSXb98lDB1+n3rWO6iICV1b3rTGO8MTGhh3JapwdHyccNpScEqu5UMz0zBEb3M2XAdqR9RChMcpNjASd5XBZlieMgIpodcdNW3CQ9lrZ0xP4gblvFuylcs3FUAz8Ed4NoZ13zyKuHF54o40SjnKq/jBI1jrx++HRNQ32x8h37sIdTXG+LN8KGz+HM91zLf/xDQ7RQ6Rpt1fchx1Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6Nri-0001c4-0y for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2024 01:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Oct 2024 05:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74104 X-GNU-PR-Package: emacs Original-Received: via spool by 74104-submit@debbugs.gnu.org id=B74104.17303529736155 (code B ref 74104); Thu, 31 Oct 2024 05:37:01 +0000 Original-Received: (at 74104) by debbugs.gnu.org; 31 Oct 2024 05:36:13 +0000 Original-Received: from localhost ([127.0.0.1]:39935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6Nqr-0001bB-JO for submit@debbugs.gnu.org; Thu, 31 Oct 2024 01:36:13 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:60195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6Nql-0001ae-Nf for 74104@debbugs.gnu.org; Thu, 31 Oct 2024 01:36:07 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 7ABD01C0002; Thu, 31 Oct 2024 05:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1730352937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l5q2BIpF0gZnzRqf/1mqAQ+Ra6qv9WP40V08GpTWWeU=; b=m3xRftUKp9oFI82AQop7IUYc0pMFee8g1q3MyD4qnyd7/2upps5+K+ujGcdLMCl9LDHfvq ZyyBx9iTMfUfKAV1YHYI8AUeFWCjKDo+XgrRB6aXBAPviCwNtZiR1ftGwrPb8IO8zJUphI GvvZ34/npXi5YV5eKZpbs3Gn59DX0uj+ftVk70Rylbbe597gQ6Hhy0hZa3bqYbdjuExtuc iu5+TXI9BmlxvHRfKIuJjh//1YvNXagn87iU2EWo1vxr3SO4Q5j0VCk9u8rv5ALs3YyVvP nEQUzEtIu9lWDOCncw94OQdmnZmuoiWHD6GUA8/mHhEDLvL/bOL9m++yw3y6Ng== In-Reply-To: <86plnh4n2l.fsf@gnu.org> X-GND-Sasl: info@protesilaos.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294592 Archived-At: > From: Eli Zaretskii > Date: Wed, 30 Oct 2024 17:39:30 +0200 > >> From: Protesilaos Stavrou >> Date: Wed, 30 Oct 2024 12:14:40 +0200 >> >> Dear maintainers, >> >> When a theme is already enabled, 'custom-set-faces' has the effect of >> adding face attributes on top of the existing ones. Those that were >> present are not removed: they are blended with the new ones. >> >> This, however, is not happening when no theme is loaded. In that >> scenario, 'custom-set-faces' removes all the underlying face attributes >> and keeps only those specified in the function call. I think this is a >> mistake. > > custom-set-faces is used to set up customized faces in the user's init > files: they are the forms written by Custom when the user decides to > save the face customizations for future sessions. So I don't think > this is a mistake, and I don't see how we can change this without > catastrophic effects on everyone's init files. Indeed, I do not want to break anybody's setup or even make far-reaching changes just for this. Do you think the difference in behaviour when a theme is loaded versus when it is not is the intended design? -- Protesilaos Stavrou https://protesilaos.com