From: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org, jwe@bevo.che.wisc.edu
Subject: Re: SEGV in x_catch_errors_unwind (x86_64-unknown-linux-gnu)
Date: Mon, 27 Feb 2006 19:51:20 -0500 [thread overview]
Message-ID: <87vev0uwzb.fsf@stupidchicken.com> (raw)
In-Reply-To: <E1FDeDZ-0001WK-LA@fencepost.gnu.org> (Richard Stallman's message of "Mon, 27 Feb 2006 03:58:57 -0500")
Richard Stallman <rms@gnu.org> writes:
> I just checked in some changes to make the x error handler avoid using
> record_unwind_protect. I am unable to make Emacs crash now -- can you
> confirm this?
>
> But if it does not use record_unwind_protect, how does it ensure
> that the x error handler gets turned off if an error happens?
> Have you checked every use of x_catch_errors to make sure that no
> Lisp errors can occur before the matching call to x_uncatch_errors?
I missed two places in xselect.c where code protected in
x_catch_errors can signal Lisp errors (x_reply_selection_request and
x_get_foreign_selection), in corner cases. Since these two functions
cannot be called from a signal handler, I'll put their
x_uncatch_errors call into a record_unwind_protect.
I have checked several more times, and there is no other such
occurence---most uses of x_catch_errors just wrap one or two Xlib
calls.
next prev parent reply other threads:[~2006-02-28 0:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 21:33 SEGV in x_catch_errors_unwind (x86_64-unknown-linux-gnu) John W. Eaton
2006-02-23 2:39 ` Richard Stallman
2006-02-24 9:55 ` Richard Stallman
2006-02-25 7:45 ` John W. Eaton
2006-02-25 15:20 ` Chong Yidong
2006-02-25 15:36 ` Chong Yidong
2006-02-25 17:47 ` John W. Eaton
2006-02-25 23:29 ` Chong Yidong
2006-02-26 3:37 ` John W. Eaton
2006-02-27 8:58 ` Richard Stallman
2006-02-28 0:51 ` Chong Yidong [this message]
2006-03-05 0:59 ` Richard Stallman
2006-02-26 16:00 ` Richard Stallman
2006-02-26 12:11 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2006-02-17 8:04 John W. Eaton
[not found] <v9oe1hg44k.fsf@marauder.physik.uni-ulm.de>
2006-02-13 4:40 ` Richard M. Stallman
2006-02-13 14:04 ` Reiner Steib
2006-02-13 17:05 ` Stefan Monnier
2006-02-14 0:40 ` Richard M. Stallman
2006-02-17 14:27 ` Reiner Steib
2006-02-17 15:20 ` Reproducible crashes: dropping an URL (was: SEGV in x_catch_errors_unwind (x86_64-unknown-linux-gnu)) Reiner Steib
2006-02-17 16:01 ` Reproducible crashes: dropping an URL Stefan Monnier
2006-02-20 14:59 ` SEGV in x_catch_errors_unwind (x86_64-unknown-linux-gnu) (was: Reproducible crashes: dropping an URL) Reiner Steib
2006-02-20 15:04 ` SEGV in x_catch_errors_unwind (x86_64-unknown-linux-gnu) Stefan Monnier
2006-02-20 20:05 ` Reiner Steib
2006-02-21 4:39 ` Chong Yidong
2006-02-22 5:23 ` Richard M. Stallman
2006-02-21 5:30 ` Richard M. Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vev0uwzb.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=jwe@bevo.che.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.