url-http.el: calling the callback function for proxy connections

url-http.el: calling the callback function for proxy connections

[Klaus Straubinger]

The function url-http-activate-callback calls the callback function
after completing the URL retrieval. If the connection had been through
a proxy, the variable url-current-object contains only the proxy
reference.

All callback functions that want to evaluate or display which URL had
been retrieved are not working properly when using the variable
url-current-object or the function url-view-url that also uses
url-current-object.

My proposal is to do

  (let ((url-current-object url-http-target-url))

around

  (apply url-callback-function url-callback-arguments)

within the function url-http-activate-callback as already done in the
function url-http-handle-cookies.

This would, for example, make HTTP-EQUIV redirects handled by the W3
package work even for proxy connections.

-- 
Klaus Straubinger

Re: url-http.el: calling the callback function for proxy connections

[Magnus Henoch]

Klaus Straubinger <KSNetz@UseNet.ArcorNews.DE> writes:

> The function url-http-activate-callback calls the callback function
> after completing the URL retrieval. If the connection had been through
> a proxy, the variable url-current-object contains only the proxy
> reference.
> [...]

Thanks for the report, and sorry about the delay...  I fixed the
problem in a different way, making url-current-object always be the
object retrieved.  Does the current CVS version work for you?

Magnus

Re: url-http.el: calling the callback function for proxy connections

[Klaus Straubinger]

Magnus Henoch <mange@freemail.hu> wrote:

> I fixed the problem in a different way, making url-current-object
> always be the object retrieved.

That is a very sensible approach, in my opinion.

Maybe it could be possible now to get rid of the variable
url-http-target-url. It had been introduced because for proxy
connections url-current-object does not contain the object to be
retrieved, as far as I remember.

> Does the current CVS version work for you?

Yes, now it works fine.

-- 
Klaus Straubinger