From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Image autodetection Date: Tue, 30 Jan 2007 11:58:18 -0500 Message-ID: <87veiotpsl.fsf@stupidchicken.com> References: <878xflr6vd.fsf@stupidchicken.com> <45BF0A1B.70202@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1170176352 24794 80.91.229.12 (30 Jan 2007 16:59:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 30 Jan 2007 16:59:12 +0000 (UTC) Cc: emacs-devel@gnu.org, Jason Rumney To: "Juanma Barranquero" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 30 17:59:02 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HBwJx-0002ZB-Ex for ged-emacs-devel@m.gmane.org; Tue, 30 Jan 2007 17:59:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HBwJw-0001HV-Is for ged-emacs-devel@m.gmane.org; Tue, 30 Jan 2007 11:59:00 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HBwJj-0001HG-SH for emacs-devel@gnu.org; Tue, 30 Jan 2007 11:58:47 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HBwJi-0001H8-IZ for emacs-devel@gnu.org; Tue, 30 Jan 2007 11:58:46 -0500 Original-Received: from south-station-annex.mit.edu ([18.72.1.2]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HBwJg-0000q1-Js; Tue, 30 Jan 2007 11:58:45 -0500 Original-Received: from grand-central-station.mit.edu (GRAND-CENTRAL-STATION.MIT.EDU [18.7.21.82]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id l0UGwT4d014730; Tue, 30 Jan 2007 11:58:29 -0500 (EST) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by grand-central-station.mit.edu (8.13.6/8.9.2) with ESMTP id l0UGwLNj000719; Tue, 30 Jan 2007 11:58:22 -0500 (EST) Original-Received: from localhost (MAIN-TWELVE-FOUR-EIGHTY-THREE.MIT.EDU [18.19.6.228]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id l0UGwJ69002877; Tue, 30 Jan 2007 11:58:19 -0500 (EST) Original-Received: from cyd by localhost with local (Exim 3.36 #1 (Debian)) id 1HBwJG-0000zh-00; Tue, 30 Jan 2007 11:58:18 -0500 In-Reply-To: (Juanma Barranquero's message of "Tue\, 30 Jan 2007 13\:11\:55 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.93 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-detected-kernel: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65644 Archived-At: "Juanma Barranquero" writes: > On 1/30/07, Juanma Barranquero wrote: > >> so I like Richard's idea of bypassing #1 of Chong's >> proposals (no more options, please!) and just implementing #2 (with >> image-toggle-display disabled, as you note). > > Something like the attached patch, which couldn't be simpler. > - (if (and (display-images-p) > - (not (get-text-property (point-min) 'display))) > - (image-toggle-display) > - ;; Set next vars when image is already displayed but local > - ;; variables were cleared by kill-all-local-variables > - (setq cursor-type nil truncate-lines t)) > + (setq cursor-type nil truncate-lines t) This last line should not be present; its purpose was to hide the cursor in case we are already displaying as an image and run image-mode again. I've checked in the patch, with this additional correction.