22.1.50; [ERC] erc-default-port should be an integer or a string service (not a string number)

* 22.1.50; [ERC] erc-default-port should be an integer or a string service (not a string number)
@ 2007-09-02 13:31 Luca Capello
  2007-09-03  1:35 ` Michael Olson
  0 siblings, 1 reply; 3+ messages in thread
From: Luca Capello @ 2007-09-02 13:31 UTC (permalink / raw)
  To: emacs-pretest-bug; +Cc: rfrancoise

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

I started to use TOR and in my .emacs I've:

  (setq
   socks-noproxy '("localhost" "127.0.0.1")
   socks-override-functions t
   socks-server '("Default server" "127.0.0.1" 9050 5))
  (require 'socks)

Whenever I tried to connect to the TOR server at Freenode.net [1], I
obtain the following error:
=====
ELISP> (erc :server "mejokbp2brhw4omd.onion")
*** Eval error ***  Wrong type argument: integerp, nil
ELISP> 

Debugger entered--Lisp error: (wrong-type-argument integerp nil)
  lsh(nil -8)
  socks-send-command(#<process socks<1>> 1 3 "mejokbp2brhw4omd.onion" nil)
  open-network-stream("erc-mejokbp2brhw4omd.onion-6667" nil "mejokbp2brhw4omd.onion" "6667")
  erc-server-connect("mejokbp2brhw4omd.onion" "6667" #<buffer mejokbp2brhw4omd.onion:6667>)
  erc-open("mejokbp2brhw4omd.onion" "6667" "gismo" "Luca Capello" t nil)
  erc(:server "mejokbp2brhw4omd.onion")
  eval((erc :server "mejokbp2brhw4omd.onion"))
  eval-expression((erc :server "mejokbp2brhw4omd.onion") nil)
  call-interactively(eval-expression)
=====

This is because erc-default-port (lisp/erc/erc.el:1463) defines the
port number as a string, thus breaking socks-find-services-entry
(lisp/net/socks.el:551).

While upstream ERC switches to "ircd" as erc-default-port (which works
nicely with socks-find-services-entry), to be consistent with
open-network-stream (lisp/subr.el:1544) I'd suggest to rename all
erc*port to erc*service (but this will be a big change).

Thx, bye,
Gismo / Luca

Footnotes: 
[1] http://freenode.net/irc_servers.shtml#tor

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/22.1.50/etc/DEBUG for instructions.

In GNU Emacs 22.1.50.1 (x86_64-pc-linux-gnu)
 of 2007-08-24 on elegiac, modified by Debian
 (Debian emacs-snapshot package, version 1:20070824-1)
configured using `configure  '--build' 'x86_64-linux-gnu' '--host' 'x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/22.1.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/22.1.50/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/22.1.50/leim' '--with-x=no' 'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  gnus-topic-mode: t
  gnus-undo-mode: t
  display-battery-mode: t
  display-time-mode: t
  show-paren-mode: t
  encoded-kbd-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
x q ESC [ A L C-s I t a l i a n C-s ESC [ B ESC [ A 
RET RET ESC [ B RET ESC [ B ESC [ A C-x o ESC [ B ESC 
[ B ESC [ B C-x o q l g ESC [ B ESC [ B ESC [ B ESC 
[ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B 
ESC [ B ESC [ B ESC [ B ESC [ B ESC [ B RET ESC [ B 
ESC [ B ESC [ B ESC [ A ESC [ A ESC [ A $ # # ESC [ 
B ESC [ B # # ESC [ A ESC [ A B j x ESC [ A ESC [ A 
# # ESC [ A ESC [ A B m C-a C-k n n m l TAB b o TAB 
RET x q RET RET B r RET ESC [ B RET ESC v ESC C-v B 
r RET x q l ESC [ A ESC [ A ESC [ A RET ESC [ B ESC 
[ B ESC [ B ESC [ B ESC [ B ESC [ B RET R q C-x k RET 
y C-x o ESC u ESC [ A q l C-c ESC f h C-c C-g C-x k 
RET C-c ESC f g ESC x e m a DEL DEL DEL r e p o r TAB 
e m TAB DEL DEL DEL DEL DEL DEL d e TAB RET C-g C-h 
f d DEL r e p o TAB r TAB - d e TAB RET C-x 1 ESC x 
r e p o r t - e m TAB b u TAB RET

Recent messages:
Entering debugger...
Back to top level.
Buffer *reply to Luca Capello* modified; kill anyway? (y or n) 
Exiting summary buffer and applying spam rules
Marking spam as expired without moving it
Report a bug for a [P]ackage or [F]ile: (default P) 
Quit
Making completion list...
Type C-x 1 to remove help window.  
Loading emacsbug...done

^ permalink raw reply	[flat|nested] 3+ messages in thread