From: Karl Fogel <kfogel@red-bean.com>
To: David Reitter <dreitter@inf.ed.ac.uk>
Cc: Juanma Barranquero <lekktu@gmail.com>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: saveplace: don't ask for coding system
Date: Sun, 02 Dec 2007 13:26:15 -0800 [thread overview]
Message-ID: <87ve7gn5zc.fsf@red-bean.com> (raw)
In-Reply-To: <06675819-C4A8-4D78-AD59-0A2AF296AC7E@inf.ed.ac.uk> (David Reitter's message of "Sun\, 2 Dec 2007 16\:51\:57 +0000")
David Reitter <dreitter@inf.ed.ac.uk> writes:
>> I think you should also add a "-*- coding: XXX -*-" line to the file.
>
> Good idea. I left the coding system at `utf-8', because that's what
> ido seems to use. If there are characters not in utf-8 that file
> systems accept for file names, it should probably be emacs-mule.
I already committed a version of this change:
$ head -7 lisp/ChangeLog
2007-12-02 Karl Fogel <kfogel@red-bean.com>
* saveplace.el (save-place-alist-to-file): Use `utf-8' coding
system when writing, and set it in the first-line file variables.
Based on a patch by David Reitter <dreitter{_AT_}inf.ed.ac.uk>
and a suggestion by Juanma Barranquero.
$ cvs ci -F lisp/msg lisp/saveplace.el lisp/ChangeLog
/cvsroot/emacs/emacs/lisp/saveplace.el,v <-- lisp/saveplace.el
new revision: 1.40; previous revision: 1.39
/cvsroot/emacs/emacs/lisp/ChangeLog,v <-- lisp/ChangeLog
new revision: 1.12354; previous revision: 1.12353
Mailing notification to emacs-commit@gnu.org... sent.
Mailing diffs to emacs-diffs@gnu.org... 2 sent.
$
I think utf-8 will be fine, practically speaking.
Just now, I've made a followup tweak based on your most recent patch:
$ head -6 lisp/ChangeLog
2007-12-02 Karl Fogel <kfogel@red-bean.com>
* saveplace.el (save-place-alist-to-file): Set
coding-system-for-write once and refer to it throughout.
Based on a patch by David Reitter <dreitter{_AT_}inf.ed.ac.uk>.
$ cvs ci -F lisp/msg lisp/saveplace.el lisp/ChangeLog
/cvsroot/emacs/emacs/lisp/saveplace.el,v <-- lisp/saveplace.el
new revision: 1.41; previous revision: 1.40
/cvsroot/emacs/emacs/lisp/ChangeLog,v <-- lisp/ChangeLog
new revision: 1.12355; previous revision: 1.12354
Mailing notification to emacs-commit@gnu.org... sent.
Mailing diffs to emacs-diffs@gnu.org... 2 sent.
$
> I'll post a separate patch for log level based message filtering
> another time.
I already committed a version of that today too:
$ head -9 lisp/ChangeLog
2007-12-02 Karl Fogel <kfogel@red-bean.com>
Offer option for saveplace to be quiet about loading and saving.
Suggested by: David Reitter <dreitter{_AT_}inf.ed.ac.uk>
* lisp/saveplace.el (save-place-quiet): New customizable boolean.
(save-place-alist-to-file, load-save-place-alist-from-file): Use it
to determine whether to print loading/saving messages.
$ cvs ci -F m lisp/saveplace.el lisp/ChangeLog
/cvsroot/emacs/emacs/lisp/saveplace.el,v <-- lisp/saveplace.el
new revision: 1.39; previous revision: 1.38
/cvsroot/emacs/emacs/lisp/ChangeLog,v <-- lisp/ChangeLog
new revision: 1.12351; previous revision: 1.12350
Mailing notification to emacs-commit@gnu.org... sent.
Mailing diffs to emacs-diffs@gnu.org... 2 sent.
$
Best,
-Karl
next prev parent reply other threads:[~2007-12-02 21:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 14:46 saveplace: don't ask for coding system David Reitter
2007-11-28 21:47 ` Eli Zaretskii
2007-11-29 0:25 ` David Reitter
2007-12-03 1:04 ` General variable for verbosity level. (was: saveplace: don't ask for coding system) Karl Fogel
2007-12-03 20:22 ` David Reitter
2007-12-03 21:44 ` General variable for verbosity level Karl Fogel
2007-12-03 22:34 ` Reiner Steib
2007-11-29 9:04 ` saveplace: don't ask for coding system Juanma Barranquero
2007-11-29 21:04 ` Eli Zaretskii
2007-11-30 9:17 ` Juanma Barranquero
2007-11-29 9:05 ` Juanma Barranquero
2007-12-02 16:51 ` David Reitter
2007-12-02 21:26 ` Karl Fogel [this message]
2007-12-02 21:31 ` David Reitter
2007-12-02 23:23 ` Karl Fogel
2007-12-03 4:18 ` Eli Zaretskii
2007-12-03 10:59 ` Karl Fogel
2007-12-03 11:06 ` Juanma Barranquero
2007-12-03 21:02 ` Stephen J. Turnbull
2007-12-03 20:48 ` Eli Zaretskii
2007-12-03 21:32 ` Karl Fogel
2007-12-04 4:20 ` Eli Zaretskii
2007-12-04 6:17 ` Karl Fogel
2007-12-04 20:57 ` Eli Zaretskii
2007-12-04 16:40 ` Juanma Barranquero
2007-12-04 21:32 ` Eli Zaretskii
2007-12-04 22:24 ` Stefan Monnier
2007-12-05 4:52 ` Eli Zaretskii
2007-12-05 8:49 ` Juanma Barranquero
2007-12-05 18:25 ` Eli Zaretskii
2007-12-05 20:05 ` Juanma Barranquero
2007-12-06 4:21 ` Eli Zaretskii
2007-12-06 12:38 ` Juanma Barranquero
2007-12-04 22:51 ` Juanma Barranquero
2007-12-04 16:55 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ve7gn5zc.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=dreitter@inf.ed.ac.uk \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.