assuming light or dark background

assuming light or dark background

[jidanni]

RFCs are unreadable now for me. Must be due to

  (defface rfcview-headlink-face
    '((t (:foreground "blue"))
      (t (:bold t)))
    "Face used for hyperlinks to headings."
    :group 'rfcview)

making some assumptions about the users' screen background color or
something. This points to a general emacs bug that there needs to be
an additional layer of indirection to soften the collision between
what the lisp author wants to do, and the environment where it ends up
getting done... without the user having to customize again for each
program... Indeed, I bet the half of all the .el authors in the world
assumed dark backgrounds and half assumed light backgrounds too!

There the problem should be attacked at its root, not by just telling
the user to

> Type M-x customize ...

Re: assuming light or dark background

[Jason Rumney]

jidanni@jidanni.org wrote:
> RFCs are unreadable now for me. Must be due to
>
>   (defface rfcview-headlink-face
>     '((t (:foreground "blue"))
>       (t (:bold t)))
>     "Face used for hyperlinks to headings."
>     :group 'rfcview)
>   

This doesn't appear to be part of Emacs. Probably a better way of 
defining that face is

(defface rfcview-headlink-face
    '((t (:inherit 'link)))
    "Face used for hyperlinks to headngs."
    :group 'rfcview)

That way it will take advantage of any variations that already exist for 
the built-in link face, such as light, dark, grayscale, or user 
customizations.

Re: assuming light or dark background

[Dave Love]

Jason Rumney <jasonr@gnu.org> writes:

> jidanni@jidanni.org wrote:
>> RFCs are unreadable now for me. Must be due to
>>
>>   (defface rfcview-headlink-face
>>     '((t (:foreground "blue"))
>>       (t (:bold t)))
>>     "Face used for hyperlinks to headings."
>>     :group 'rfcview)
>>
>
> This doesn't appear to be part of Emacs.

Indeed.  It isn't part of
<URL:http://www.loveshack.ukfsn.org/emacs/rfcview.el> either.

> Probably a better way of
> defining that face is
>
> (defface rfcview-headlink-face
>    '((t (:inherit 'link)))
>    "Face used for hyperlinks to headngs."
>    :group 'rfcview)

(facep 'link)
  => nil

> That way it will take advantage of any variations that already exist
> for the built-in link face, such as light, dark, grayscale, or user
> customizations.

If there was a face defined for hyperlinks in the relevant versions of
Emacs, it would be appropriate just to use it (with the `face' custom
type), not define more vanity faces.  That was what we intended for
Emacs 21 as far as I remember, even if it didn't get done well.  I
shouldn't have 281 separately-defined faces in my current session --
Gnus being the biggest culprit.

Re: assuming light or dark background

[jidanni]

DL> Indeed.  It isn't part of
DL> <URL:http://www.loveshack.ukfsn.org/emacs/rfcview.el> either.
All I know is
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=464940
Hope you all can work it out.