From: Tassilo Horn <tassilo@member.fsf.org>
To: emacs-devel@gnu.org
Cc: 3865@emacsbugs.donarmstrong.com
Subject: Patch for #3865: Would somebody please commit on HEAD and branch?
Date: Fri, 17 Jul 2009 20:51:58 +0200 [thread overview]
Message-ID: <87vdlr2ldd.fsf@thinkpad.tsdh.de> (raw)
Hi all,
this patch fixes the inconveniences Reiner pointed out in #3865. Could
somebody please commit it for me on branch and head?
I'm to busy to read up how to merge between branches with CVS -- I'm
going to marry tomorrow! :-)
--8<---------------cut here---------------start------------->8---
2009-07-16 Tassilo Horn <tassilo@member.fsf.org>
* doc-view.el (doc-view-initiate-display): Add yes-or-no-p if
rendering of pngs is not possible instead of messaging a long
description.
--8<---------------cut here---------------end--------------->8---
--8<---------------cut here---------------start------------->8---
Index: lisp/doc-view.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/doc-view.el,v
retrieving revision 1.87
diff -u -r1.87 doc-view.el
--- lisp/doc-view.el 2 Apr 2009 21:12:56 -0000 1.87
+++ lisp/doc-view.el 17 Jul 2009 18:44:18 -0000
@@ -1078,15 +1078,12 @@
"editing or viewing the document."))))
(message
"%s"
- (substitute-command-keys
- (concat "No PNG support available or some conversion utility for "
- (file-name-extension doc-view-buffer-file-name)" files is missing. "
- "Type \\[doc-view-toggle-display] to switch to "
- (if (eq doc-view-doc-type 'ps)
- "ps-mode"
- "fundamental-mode")
- ", \\[doc-view-open-text] to show the doc as text in a separate buffer "
- " or \\[doc-view-kill-proc-and-buffer] to kill this buffer.")))))
+ (concat "No PNG support available or some conversion utility for "
+ (file-name-extension doc-view-buffer-file-name) " files is missing."))
+ (if (and (executable-find doc-view-pdftotext-program)
+ (yes-or-no-p "Cannot render file. View extracted text instead? "))
+ (doc-view-open-text)
+ (doc-view-toggle-display))))
(defvar bookmark-make-record-function)
--8<---------------cut here---------------end--------------->8---
Bye,
Tassilo
next reply other threads:[~2009-07-17 18:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 18:51 Tassilo Horn [this message]
2009-07-17 19:17 ` Patch for #3865: Would somebody please commit on HEAD and branch? Bastien
2009-07-17 19:34 ` Lennart Borgman
2009-07-17 19:47 ` Tassilo Horn
2009-07-18 5:51 ` Bastien
2009-07-17 19:17 ` bug#3865: " Bastien
2009-07-17 19:44 ` Chong Yidong
2009-07-16 9:01 ` bug#3865: 23.0.95; doc-view-mode with PDF without PNG support Reiner Steib
2009-07-17 19:50 ` bug#3865: marked as done (23.0.95; doc-view-mode with PDF without PNG support) Emacs bug Tracking System
2009-07-19 5:34 ` Patch for #3865: Would somebody please commit on HEAD and branch? Stefan Monnier
2009-07-19 5:34 ` bug#3865: " Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdlr2ldd.fsf@thinkpad.tsdh.de \
--to=tassilo@member.fsf.org \
--cc=3865@emacsbugs.donarmstrong.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.