* bug#4698: 23.1; C-l in gnus differs from other modes @ 2009-10-11 1:22 ` Tom Tromey 2009-10-14 18:23 ` Reiner Steib ` (2 more replies) 0 siblings, 3 replies; 6+ messages in thread From: Tom Tromey @ 2009-10-11 1:22 UTC (permalink / raw) To: bug-gnu-emacs Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, and to the gnu.emacs.bug news group. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: Emacs changed the default C-l binding to recenter-top-bottom. However, C-l in the gnus summary buffer is still gnus-recenter, which just calls recenter. I think it would be nice if gnus followed the user's setting here. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /usr/share/emacs/23.1/etc/DEBUG for instructions. In GNU Emacs 23.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.16.6) of 2009-09-29 on x86-7.fedora.phx.redhat.com Windowing system distributor `The X.Org Foundation', version 11.0.10603901 configured using `configure '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i586-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i586-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-bu ffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: shell-dirtrack-mode: t diff-auto-refine-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-spelling-mode: t erc-truncate-mode: t flyspell-mode: t eldoc-mode: t erc-status-mode: t erc-services-mode: t erc-networks-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: n SPC n SPC SPC n SPC SPC n SPC SPC SPC n SPC SPC SPC n SPC SPC n n RET RET n C-u RET RET RET RET RET RET RET RET SPC n SPC n SPC n SPC n SPC n SPC n SPC SPC SPC SPC DEL DEL SPC SPC SPC n q s C-f C-l n SPC k n c SPC C-f C-f = c SPC SPC c SPC SPC C-u C-n C-n C-p d SPC C-u RET RET RET C-u d d q C-l n SPC c SPC n n SPC E q SPC E SPC q SPC SPC E q SPC C-n n SPC SPC E SPC SPC E SPC SPC SPC SPC E SPC SPC SPC SPC SPC E SPC P SPC SPC SPC SPC N E SPC E SPC SPC E SPC E SPC E SPC E SPC C-u RET E q C-l SPC SPC SPC E SPC SPC SPC SPC E SPC E SPC P SPC N E SPC E SPC SPC SPC E SPC E SPC E SPC SPC E SPC SPC E SPC P SPC N E SPC E SPC P N E SPC E SPC C-f E q SPC q SPC SPC E q C-l n n SPC q n SPC E E q n n SPC 5 0 RET ESC > ESC < C-v Q y SPC 1 0 0 RET C-v C-v C-u C-n C-u C-n C-l C-l C-l C-l C-l SPC C-h k C-l C-x o C-n C-n C-x o C-x o C-n C-e C-b C-b C-b C-b RET C-x 1 C-l C-h c C-l C-h k C-g C-h k C-l C-x o C-x 1 C-c b C-x k C-g ESC x r e p o r t - e m TAB b TAB RET Recent messages: Retrieving newsgroup: nnml:mail.other... Fetching headers for nnml:mail.other...done Scoring...done Scoring...done Generating summary...done Type "q" to restore this window. uncompressing gnus-sum.el.gz...done Note: file is write protected C-l runs the command recenter-top-bottom Type C-x 1 to delete the help window. Quit Tom ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4698: 23.1; C-l in gnus differs from other modes 2009-10-11 1:22 ` bug#4698: 23.1; C-l in gnus differs from other modes Tom Tromey @ 2009-10-14 18:23 ` Reiner Steib [not found] ` <87vdihomv7.fsf@marauder.physik.uni-ulm.de> 2009-11-30 18:30 ` bug#4698: marked as done (23.1; C-l in gnus differs from other modes) Emacs bug Tracking System 2 siblings, 0 replies; 6+ messages in thread From: Reiner Steib @ 2009-10-14 18:23 UTC (permalink / raw) To: Tom Tromey; +Cc: 4698, ding On Sun, Oct 11 2009, Tom Tromey wrote: > Emacs changed the default C-l binding to recenter-top-bottom. > However, C-l in the gnus summary buffer is still gnus-recenter, > which just calls recenter. > I think it would be nice if gnus followed the user's setting here. Here's a mostly untested patch: --8<---------------cut here---------------start------------->8--- --- gnus-sum.el 9 Sep 2009 09:31:35 -0000 7.240 +++ gnus-sum.el 14 Oct 2009 18:19:46 -0000 @@ -6722,7 +6725,9 @@ (when (and gnus-auto-center-summary (not (eq gnus-auto-center-summary 'vertical))) (gnus-horizontal-recenter)) - (recenter n)) + (if (fboundp 'recenter-top-bottom) + (recenter-top-bottom n) + (recenter n))) (defun gnus-summary-recenter () "Center point in the summary window. --8<---------------cut here---------------end--------------->8--- Could you please test it for a while and report back? Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <87vdihomv7.fsf@marauder.physik.uni-ulm.de>]
* bug#4698: 23.1; C-l in gnus differs from other modes [not found] ` <87vdihomv7.fsf@marauder.physik.uni-ulm.de> @ 2009-10-16 7:46 ` Katsumi Yamaoka [not found] ` <b4m7huvzspt.fsf@jpl.org> 1 sibling, 0 replies; 6+ messages in thread From: Katsumi Yamaoka @ 2009-10-16 7:46 UTC (permalink / raw) To: Tom Tromey; +Cc: 4698, Gnus >>>>> Reiner Steib wrote: > On Sun, Oct 11 2009, Tom Tromey wrote: >> Emacs changed the default C-l binding to recenter-top-bottom. >> However, C-l in the gnus summary buffer is still gnus-recenter, >> which just calls recenter. >> I think it would be nice if gnus followed the user's setting here. > Here's a mostly untested patch: [...] > Could you please test it for a while and report back? Looks good. Thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <b4m7huvzspt.fsf@jpl.org>]
* bug#4698: 23.1; C-l in gnus differs from other modes [not found] ` <b4m7huvzspt.fsf@jpl.org> @ 2009-11-30 18:24 ` Reiner Steib 0 siblings, 0 replies; 6+ messages in thread From: Reiner Steib @ 2009-11-30 18:24 UTC (permalink / raw) To: Tom Tromey, 4698, ding On Fri, Oct 16 2009, Katsumi Yamaoka wrote: >>>>>> Reiner Steib wrote: >> On Sun, Oct 11 2009, Tom Tromey wrote: > >>> Emacs changed the default C-l binding to recenter-top-bottom. >>> However, C-l in the gnus summary buffer is still gnus-recenter, >>> which just calls recenter. >>> I think it would be nice if gnus followed the user's setting here. > >> Here's a mostly untested patch: > > [...] > >> Could you please test it for a while and report back? > > Looks good. Thanks. Closing this bug as it was fixed by this change: 2009-11-29 Juri Linkov <juri@jurta.org> * gnus-sum.el (gnus-recenter): Use `recenter-top-bottom' when it is fboundp in GNU Emacs 23.1. Put `isearch-scroll' property on `gnus-recenter'. (Bug#4698, Bug#4981) Bye, Reiner ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4698: marked as done (23.1; C-l in gnus differs from other modes) 2009-10-11 1:22 ` bug#4698: 23.1; C-l in gnus differs from other modes Tom Tromey 2009-10-14 18:23 ` Reiner Steib [not found] ` <87vdihomv7.fsf@marauder.physik.uni-ulm.de> @ 2009-11-30 18:30 ` Emacs bug Tracking System 2 siblings, 0 replies; 6+ messages in thread From: Emacs bug Tracking System @ 2009-11-30 18:30 UTC (permalink / raw) To: Reiner Steib [-- Attachment #1: Type: text/plain, Size: 893 bytes --] Your message dated Mon, 30 Nov 2009 19:24:43 +0100 with message-id <87638r27mc.fsf@marauder.physik.uni-ulm.de> and subject line Re: bug#4698: 23.1; C-l in gnus differs from other modes has caused the Emacs bug report #4698, regarding 23.1; C-l in gnus differs from other modes to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) -- 4698: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4698 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 7001 bytes --] From: Tom Tromey <tromey@redhat.com> To: bug-gnu-emacs@gnu.org Subject: 23.1; C-l in gnus differs from other modes Date: Sat, 10 Oct 2009 19:22:54 -0600 Message-ID: <m3vdim4tch.fsf@fleche.redhat.com> Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, and to the gnu.emacs.bug news group. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: Emacs changed the default C-l binding to recenter-top-bottom. However, C-l in the gnus summary buffer is still gnus-recenter, which just calls recenter. I think it would be nice if gnus followed the user's setting here. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /usr/share/emacs/23.1/etc/DEBUG for instructions. In GNU Emacs 23.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.16.6) of 2009-09-29 on x86-7.fedora.phx.redhat.com Windowing system distributor `The X.Org Foundation', version 11.0.10603901 configured using `configure '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i586-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i586-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-bu ffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: shell-dirtrack-mode: t diff-auto-refine-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-spelling-mode: t erc-truncate-mode: t flyspell-mode: t eldoc-mode: t erc-status-mode: t erc-services-mode: t erc-networks-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: n SPC n SPC SPC n SPC SPC n SPC SPC SPC n SPC SPC SPC n SPC SPC n n RET RET n C-u RET RET RET RET RET RET RET RET SPC n SPC n SPC n SPC n SPC n SPC n SPC SPC SPC SPC DEL DEL SPC SPC SPC n q s C-f C-l n SPC k n c SPC C-f C-f = c SPC SPC c SPC SPC C-u C-n C-n C-p d SPC C-u RET RET RET C-u d d q C-l n SPC c SPC n n SPC E q SPC E SPC q SPC SPC E q SPC C-n n SPC SPC E SPC SPC E SPC SPC SPC SPC E SPC SPC SPC SPC SPC E SPC P SPC SPC SPC SPC N E SPC E SPC SPC E SPC E SPC E SPC E SPC C-u RET E q C-l SPC SPC SPC E SPC SPC SPC SPC E SPC E SPC P SPC N E SPC E SPC SPC SPC E SPC E SPC E SPC SPC E SPC SPC E SPC P SPC N E SPC E SPC P N E SPC E SPC C-f E q SPC q SPC SPC E q C-l n n SPC q n SPC E E q n n SPC 5 0 RET ESC > ESC < C-v Q y SPC 1 0 0 RET C-v C-v C-u C-n C-u C-n C-l C-l C-l C-l C-l SPC C-h k C-l C-x o C-n C-n C-x o C-x o C-n C-e C-b C-b C-b C-b RET C-x 1 C-l C-h c C-l C-h k C-g C-h k C-l C-x o C-x 1 C-c b C-x k C-g ESC x r e p o r t - e m TAB b TAB RET Recent messages: Retrieving newsgroup: nnml:mail.other... Fetching headers for nnml:mail.other...done Scoring...done Scoring...done Generating summary...done Type "q" to restore this window. uncompressing gnus-sum.el.gz...done Note: file is write protected C-l runs the command recenter-top-bottom Type C-x 1 to delete the help window. Quit Tom [-- Attachment #3: Type: message/rfc822, Size: 2539 bytes --] From: Reiner Steib <reinersteib+gmane@imap.cc> To: Tom Tromey <tromey@redhat.com>, 4698@emacsbugs.donarmstrong.com, ding@gnus.org Subject: Re: bug#4698: 23.1; C-l in gnus differs from other modes Date: Mon, 30 Nov 2009 19:24:43 +0100 Message-ID: <87638r27mc.fsf@marauder.physik.uni-ulm.de> On Fri, Oct 16 2009, Katsumi Yamaoka wrote: >>>>>> Reiner Steib wrote: >> On Sun, Oct 11 2009, Tom Tromey wrote: > >>> Emacs changed the default C-l binding to recenter-top-bottom. >>> However, C-l in the gnus summary buffer is still gnus-recenter, >>> which just calls recenter. >>> I think it would be nice if gnus followed the user's setting here. > >> Here's a mostly untested patch: > > [...] > >> Could you please test it for a while and report back? > > Looks good. Thanks. Closing this bug as it was fixed by this change: 2009-11-29 Juri Linkov <juri@jurta.org> * gnus-sum.el (gnus-recenter): Use `recenter-top-bottom' when it is fboundp in GNU Emacs 23.1. Put `isearch-scroll' property on `gnus-recenter'. (Bug#4698, Bug#4981) Bye, Reiner ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4698: 23.1; C-l in gnus differs from other modes [not found] <87638r27mc.fsf@marauder.physik.uni-ulm.de> 2009-10-11 1:22 ` bug#4698: 23.1; C-l in gnus differs from other modes Tom Tromey @ 2009-11-30 19:49 ` Juri Linkov 1 sibling, 0 replies; 6+ messages in thread From: Juri Linkov @ 2009-11-30 19:49 UTC (permalink / raw) To: Reiner Steib; +Cc: 4698 > Closing this bug as it was fixed by this change: Thanks. I don't know how I missed this bug report. > 2009-11-29 Juri Linkov <juri@jurta.org> > > * gnus-sum.el (gnus-recenter): Use `recenter-top-bottom' > when it is fboundp in GNU Emacs 23.1. Put `isearch-scroll' property > on `gnus-recenter'. (Bug#4698, Bug#4981) ========= Could you please also update gnus/ChangeLog in CVS adding a reference to Bug#4698 to gnus/ChangeLog. Or did you already update this in Gnus CVS that will be later synced to the Emacs CVS? -- Juri Linkov http://www.jurta.org/emacs/ ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-11-30 19:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87638r27mc.fsf@marauder.physik.uni-ulm.de>
2009-10-11 1:22 ` bug#4698: 23.1; C-l in gnus differs from other modes Tom Tromey
2009-10-14 18:23 ` Reiner Steib
[not found] ` <87vdihomv7.fsf@marauder.physik.uni-ulm.de>
2009-10-16 7:46 ` Katsumi Yamaoka
[not found] ` <b4m7huvzspt.fsf@jpl.org>
2009-11-30 18:24 ` Reiner Steib
2009-11-30 18:30 ` bug#4698: marked as done (23.1; C-l in gnus differs from other modes) Emacs bug Tracking System
2009-11-30 19:49 ` bug#4698: 23.1; C-l in gnus differs from other modes Juri Linkov
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.