From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#5475: Archives with filenames with square brackets Date: Wed, 27 Jan 2010 11:57:46 -0500 Message-ID: <87vden4h9x.fsf@stupidchicken.com> References: <874omakv2m.fsf@mail.jurta.org> <87eilca86n.fsf@stupidchicken.com> <83r5pc4jye.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1264612742 4151 80.91.229.12 (27 Jan 2010 17:19:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Jan 2010 17:19:02 +0000 (UTC) Cc: 5475@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 27 18:18:58 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NaBXQ-0000iQ-7r for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jan 2010 18:18:44 +0100 Original-Received: from localhost ([127.0.0.1]:43734 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NaBXP-00011k-G5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jan 2010 12:18:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NaBOz-0001d8-2c for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 12:10:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NaBOu-0001Yc-4L for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 12:10:00 -0500 Original-Received: from [199.232.76.173] (port=53791 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NaBOt-0001YL-Ry for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 12:09:55 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54045) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NaBOt-0006cb-IG for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 12:09:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NaBDO-0004UQ-4R; Wed, 27 Jan 2010 11:58:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Jan 2010 16:58:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5475 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5475-submit@debbugs.gnu.org id=B5475.126461147417249 (code B ref 5475); Wed, 27 Jan 2010 16:58:02 +0000 Original-Received: (at 5475) by debbugs.gnu.org; 27 Jan 2010 16:57:54 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NaBDF-0004UA-N1 for submit@debbugs.gnu.org; Wed, 27 Jan 2010 11:57:53 -0500 Original-Received: from pantheon-po33.its.yale.edu ([130.132.50.94]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NaBDC-0004U5-VW for 5475@debbugs.gnu.org; Wed, 27 Jan 2010 11:57:51 -0500 Original-Received: from furry (dhcp128036014123.central.yale.edu [128.36.14.123]) (authenticated bits=0) by pantheon-po33.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o0RGvkx1021522 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 27 Jan 2010 11:57:46 -0500 Original-Received: by furry (Postfix, from userid 1000) id 20BFDC05D; Wed, 27 Jan 2010 09:57:46 -0700 (MST) In-Reply-To: <83r5pc4jye.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 26 Jan 2010 23:47:37 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.9 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -2.9 (--) Resent-Date: Wed, 27 Jan 2010 11:58:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34758 Archived-At: Eli Zaretskii writes: > First, why not use shell-quote-argument, instead of requiring comint? I wasn't sure whether it was only [] that was handled specially, or the usual shell wildcards. But I see now that it is the latter, as you say. So shell-quote-argument is indeed the correct thing. > Second, could someone please see if pkzip also expands wildcards > internally? If it does not, the quoting will need to be done only in > the non-pkzip branch. We also need to test this on MS-Windows. I have no way to check this. Looks like pkzip is Windows-only. > But most importantly, this patch is not clean, IMO: it hardcodes into > archive-zip-extract (the function) some knowledge of what can be the > possible values of archive-zip-extract the defcustom. What if > tomorrow there will be a 3rd possibility, in addition to pkzip and > unzip? > > That is why I thought about some less trivial patch: add to the data > structures that are values of these defcustom's a flag to indicate > whether the file name needs to be quoted or not. Well, archive-zip-extract already branches for pkzip/unzip, so whatever uncleanliness that's associated with is already present...