From: Chong Yidong <cyd@stupidchicken.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 5475@debbugs.gnu.org
Subject: bug#5475: Archives with filenames with square brackets
Date: Wed, 27 Jan 2010 11:57:46 -0500 [thread overview]
Message-ID: <87vden4h9x.fsf@stupidchicken.com> (raw)
In-Reply-To: <83r5pc4jye.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 26 Jan 2010 23:47:37 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> First, why not use shell-quote-argument, instead of requiring comint?
I wasn't sure whether it was only [] that was handled specially, or the
usual shell wildcards. But I see now that it is the latter, as you say.
So shell-quote-argument is indeed the correct thing.
> Second, could someone please see if pkzip also expands wildcards
> internally? If it does not, the quoting will need to be done only in
> the non-pkzip branch. We also need to test this on MS-Windows.
I have no way to check this. Looks like pkzip is Windows-only.
> But most importantly, this patch is not clean, IMO: it hardcodes into
> archive-zip-extract (the function) some knowledge of what can be the
> possible values of archive-zip-extract the defcustom. What if
> tomorrow there will be a 3rd possibility, in addition to pkzip and
> unzip?
>
> That is why I thought about some less trivial patch: add to the data
> structures that are values of these defcustom's a flag to indicate
> whether the file name needs to be quoted or not.
Well, archive-zip-extract already branches for pkzip/unzip, so whatever
uncleanliness that's associated with is already present...
next prev parent reply other threads:[~2010-01-27 16:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 17:48 bug#5475: Archives with filenames with square brackets Juri Linkov
2010-01-26 21:05 ` Chong Yidong
2010-01-26 21:47 ` Eli Zaretskii
2010-01-27 16:57 ` Chong Yidong [this message]
2010-01-27 17:35 ` Eli Zaretskii
2010-01-28 20:07 ` Chong Yidong
2010-01-28 21:05 ` Eli Zaretskii
2010-01-28 21:24 ` Lennart Borgman
2010-01-28 22:00 ` Eli Zaretskii
2010-01-30 22:59 ` Juri Linkov
2010-01-31 4:18 ` Eli Zaretskii
2010-01-31 10:56 ` Juri Linkov
2010-01-31 18:04 ` Eli Zaretskii
2010-01-31 21:59 ` Juri Linkov
2010-02-01 4:15 ` Eli Zaretskii
2010-02-01 10:34 ` Juri Linkov
2010-02-01 11:48 ` Lennart Borgman
2010-02-01 15:43 ` Stefan Monnier
2010-02-01 21:55 ` Juri Linkov
2010-02-02 0:11 ` Lennart Borgman
2010-02-02 0:46 ` Juri Linkov
2010-02-02 4:03 ` Eli Zaretskii
2010-04-18 23:14 ` Juri Linkov
2010-02-01 19:49 ` Eli Zaretskii
2010-02-01 21:21 ` Drew Adams
2010-02-01 21:52 ` Eli Zaretskii
2010-02-01 22:04 ` Drew Adams
2010-02-01 22:39 ` Juri Linkov
2010-02-01 22:41 ` Lennart Borgman
2010-02-02 0:10 ` Lennart Borgman
2010-02-02 0:42 ` Juri Linkov
2010-02-02 1:30 ` Lennart Borgman
2010-02-02 10:03 ` Juri Linkov
2010-02-03 0:17 ` Lennart Borgman
2010-02-03 0:35 ` Juri Linkov
2010-02-03 23:54 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vden4h9x.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=5475@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.