From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#5805: 23.1; abbrev-insert does not protext itself with save-excursion Date: Sat, 10 Apr 2010 12:04:13 -0400 Message-ID: <87vdbzjnuq.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1270916964 1838 80.91.229.12 (10 Apr 2010 16:29:24 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 10 Apr 2010 16:29:24 +0000 (UTC) Cc: 5805@debbugs.gnu.org To: "Maguire\, Andrew \(GE Infra\, Energy\)" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 10 18:29:23 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O0dYg-0000Hn-W0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Apr 2010 18:29:23 +0200 Original-Received: from localhost ([127.0.0.1]:52355 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0dYf-0007xn-Ub for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Apr 2010 12:29:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O0dYA-0007ii-Vu for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2010 12:28:51 -0400 Original-Received: from [140.186.70.92] (port=58334 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0dY7-0007g2-Ka for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2010 12:28:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O0dY5-0007qt-91 for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2010 12:28:47 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60767) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0dY5-0007qp-64 for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2010 12:28:45 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1O0dB8-0002As-30; Sat, 10 Apr 2010 12:05:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Apr 2010 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5805 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5805-submit@debbugs.gnu.org id=B5805.12709154578345 (code B ref 5805); Sat, 10 Apr 2010 16:05:02 +0000 Original-Received: (at 5805) by debbugs.gnu.org; 10 Apr 2010 16:04:17 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0dAP-0002AY-7p for submit@debbugs.gnu.org; Sat, 10 Apr 2010 12:04:17 -0400 Original-Received: from pantheon-po34.its.yale.edu ([130.132.50.80]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0dAN-0002AT-QQ for 5805@debbugs.gnu.org; Sat, 10 Apr 2010 12:04:16 -0400 Original-Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po34.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o3AG4Dex007686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 10 Apr 2010 12:04:13 -0400 Original-Received: by furry (Postfix, from userid 1000) id 5E93CC055; Sat, 10 Apr 2010 12:04:13 -0400 (EDT) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 10 Apr 2010 12:05:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36159 Archived-At: > In our code we use abbrev to dynamically expand certain > keywords. However, the new lisp implementation is more eager in > finding things to check, ie. it is able to look back past non-word > characters to see if an abbrev is to be found. In this situation it > is essential to do save-excursion. > > Ideally, either insert-abbrev should do a save-excursion itself or all > calls to it should. In our code, expand-abbrev is call which > internally calls abbrev-insert. > > Alternatively, is it the recommendation for user code to surround all > "abbrev" calls with save-excursion now? Do you have a recipe for reproducing a bug? By default, the abbrev code is not supposed to change point, so there should be no advantage adding a save-excursion. I don't see why we should constrain the ability of user-defined functions in `abbrev-expand-functions' to change point, if they want to. Or do you mean save-match-data?