From: Chong Yidong <cyd@stupidchicken.com>
To: "Maguire\, Andrew \(GE Infra\, Energy\)" <andrew.maguire@ge.com>
Cc: 5805@debbugs.gnu.org
Subject: bug#5805: 23.1; abbrev-insert does not protext itself with save-excursion
Date: Sat, 10 Apr 2010 12:04:13 -0400 [thread overview]
Message-ID: <87vdbzjnuq.fsf@stupidchicken.com> (raw)
In-Reply-To: <A6A1CC87D715C143988ED94326B583D301E0C9D6@BUDMLVEM09.e2k.ad.ge.com>
> In our code we use abbrev to dynamically expand certain
> keywords. However, the new lisp implementation is more eager in
> finding things to check, ie. it is able to look back past non-word
> characters to see if an abbrev is to be found. In this situation it
> is essential to do save-excursion.
>
> Ideally, either insert-abbrev should do a save-excursion itself or all
> calls to it should. In our code, expand-abbrev is call which
> internally calls abbrev-insert.
>
> Alternatively, is it the recommendation for user code to surround all
> "abbrev" calls with save-excursion now?
Do you have a recipe for reproducing a bug? By default, the abbrev code
is not supposed to change point, so there should be no advantage adding
a save-excursion. I don't see why we should constrain the ability of
user-defined functions in `abbrev-expand-functions' to change point, if
they want to.
Or do you mean save-match-data?
next prev parent reply other threads:[~2010-04-10 16:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201003291206.NAA17706@ultimate.Smallworld.co.uk>
2010-03-30 16:33 ` bug#5805: Returned mail: Cannot send message within 3 days Maguire, Andrew (GE Infra, Energy)
2010-04-10 16:04 ` Chong Yidong [this message]
2010-04-10 17:06 ` bug#5805: 23.1; abbrev-insert does not protext itself with save-excursion Maguire, Andrew (GE Infra, Energy)
2010-04-10 19:10 ` Stefan Monnier
2010-04-12 11:28 ` Maguire, Andrew (GE Infra, Energy)
2010-04-12 13:31 ` Stefan Monnier
2010-04-12 15:02 ` Maguire, Andrew (GE Infra, Energy)
2010-04-12 18:13 ` Stefan Monnier
2011-07-07 14:48 ` bug#5805: 23.3 abbrev-insert needs a limited save-excursion Bob Nnamtrop
2011-07-07 20:59 ` Stefan Monnier
2011-07-07 21:46 ` Bob Nnamtrop
2011-07-08 0:02 ` Bob Nnamtrop
2011-07-08 1:03 ` Stefan Monnier
2011-07-08 14:43 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdbzjnuq.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=5805@debbugs.gnu.org \
--cc=andrew.maguire@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.