From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?xaB0xJtww6FuIE7Em21lYw==?= Subject: Re: [PATCH] Make sure `flet' is fbound when executing `org-write-agenda'. Date: Sun, 27 Jun 2010 17:00:22 +0200 Message-ID: <87vd94tta1.fsf@gmail.com> References: <87aaqglrr3.wl%dmaus@ictsoc.de> <1277649049-14463-2-git-send-email-dmaus@ictsoc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from [140.186.70.92] (port=41536 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OStM6-00044u-NL for emacs-orgmode@gnu.org; Sun, 27 Jun 2010 11:01:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OStM4-0002qu-IY for emacs-orgmode@gnu.org; Sun, 27 Jun 2010 11:01:10 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:51957) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OStM4-0002qq-Do for emacs-orgmode@gnu.org; Sun, 27 Jun 2010 11:01:08 -0400 Received: by fxm17 with SMTP id 17so811048fxm.0 for ; Sun, 27 Jun 2010 08:01:07 -0700 (PDT) In-Reply-To: <1277649049-14463-2-git-send-email-dmaus@ictsoc.de> (David Maus's message of "Sun, 27 Jun 2010 16:30:49 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Maus Cc: emacs-orgmode@gnu.org David Maus writes: > * org-agenda.el (org-write-agenda): Make sure `flet' is fbound > at runtime. > --- > lisp/org-agenda.el | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index 8035add..957bbf2 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -2464,6 +2464,8 @@ higher priority settings." > beg (or (next-single-property-change beg 'org-filtered) > (point-max)))) > (run-hooks 'org-agenda-before-write-hook) > + ;; make sure flet is fbound at runtime > + (unless (fboundp 'flet) (require 'cl)) > (cond > ((org-bound-and-true-p org-mobile-creating-agendas) > (org-mobile-write-agenda-for-mobile file)) This, while being an obvious (and correct) solution, is unfortunately not suitable for Emacs core. You're not supposed to require the cl package at runtime (you even get a compiler warning if you do). =C5=A0t=C4=9Bp=C3=A1n