From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel,gmane.comp.encryption.gpg.gnutls.devel Subject: Re: Emacs core TLS support Date: Mon, 27 Sep 2010 09:56:45 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87vd5r8cb6.fsf@lifelogs.com> References: <878wc1vfh3.fsf@lifelogs.com> <87r5i2d00q.fsf@lifelogs.com> <87zkwqijye.fsf@stupidchicken.com> <878w4actmg.fsf@lifelogs.com> <877hju123h.fsf@stupidchicken.com> <8762yklrdk.fsf@lifelogs.com> <87wrqzhrjv.fsf@lifelogs.com> <87fwxmihyz.fsf@lifelogs.com> <8762ycfhqo.fsf@lifelogs.com> <87d3sf9soo.fsf@lifelogs.com> <87r5gh2fzj.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1285599436 3813 80.91.229.12 (27 Sep 2010 14:57:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 27 Sep 2010 14:57:16 +0000 (UTC) Cc: gnutls-devel@gnu.org To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 27 16:57:15 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P0F8i-00012Y-Ax for ged-emacs-devel@m.gmane.org; Mon, 27 Sep 2010 16:57:12 +0200 Original-Received: from localhost ([127.0.0.1]:53473 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0F8i-0004kM-2t for ged-emacs-devel@m.gmane.org; Mon, 27 Sep 2010 10:57:12 -0400 Original-Received: from [140.186.70.92] (port=42385 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0F8b-0004kH-5G for emacs-devel@gnu.org; Mon, 27 Sep 2010 10:57:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0F8W-0000m8-3r for emacs-devel@gnu.org; Mon, 27 Sep 2010 10:57:04 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:47955) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0F8V-0000lr-Qb for emacs-devel@gnu.org; Mon, 27 Sep 2010 10:57:00 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1P0F8R-0000wk-4b for emacs-devel@gnu.org; Mon, 27 Sep 2010 16:56:55 +0200 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 27 Sep 2010 16:56:55 +0200 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 27 Sep 2010 16:56:55 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 35 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:tZCbIBYXJiOPCIY7X426I21gTkA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:131000 gmane.comp.encryption.gpg.gnutls.devel:4551 Archived-At: On Mon, 27 Sep 2010 16:40:09 +0200 Lars Magne Ingebrigtsen wrote: LMI> Lars Magne Ingebrigtsen writes: >> If I return Qt when gnutls_handshake() returns zero, then I get the >> Gmail IMAP greeting, which I think it works. >> >> I'll clean it up and see whether that really fixed this... LMI> I've checked in the changes, since it works a bit better now than LMI> before. Previously, it would try to do the handshake in a loop after LMI> completing it, and that obviously doesn't work. Hmm, GNUTLS_E_SUCCESS is 0 by definition. But you say in your patch: - if (GNUTLS_E_SUCCESS == ret) + if (GNUTLS_E_SUCCESS == ret || ret == 0) { /* here we're finally done. */ GNUTLS_INITSTAGE (proc) = GNUTLS_STAGE_READY; + return Qt; } return gnutls_make_error (ret); gnutls_make_error returns Qt when the error is GNUTLS_E_SUCCESS. So none of this should be necessary. Similarly the change to gnutls.el: - (while (and (not (gnutls-error-fatalp ret)) + (while (and (not (eq ret t)) + (not (gnutls-error-fatalp ret)) If you do (gnutls-error-fatalp t) you'll get nil, so again that shouldn't have been necessary. Am I missing something? Ted