all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jari Aalto <jari.aalto@cante.net>
To: 7712@debbugs.gnu.org
Subject: bug#7712: lisp/textmodes/conf-mode.el - Unused macro expansion in conf-font-lock-keywords
Date: Wed, 22 Dec 2010 21:01:36 +0200	[thread overview]
Message-ID: <87vd2lvdgv.fsf@picasso.cante.net> (raw)

Package: emacs
Version: 23.2+1-5.1
Severity: minor

lisp/textmodes/conf-mode.el uses macro expansion backtick (`) in here:

    (defvar conf-font-lock-keywords
=>    `(;; [section] (do this first because it may look like a parameter)
        ("^[ \t]*\\[\\(.+\\)\\]" 1 'font-lock-type-face)
        ;; var=val or var[index]=val
        ("^[ \t]*\\(.+?\\)\\(?:\\[\\(.*?\\)\\]\\)?[ \t]*="
         (1 'font-lock-variable-name-face)
         (2 'font-lock-constant-face nil t))
        ;; section { ... } (do this last because some assign ...{...)
        ("^[ \t]*\\([^=:\n]+?\\)[ \t\n]*{[^{}]*?$" 1 'font-lock-type-face prepend))
      "Keywords to hilight in Conf mode.")

Everywhere else it uses single quote:

    (defvar conf-javaprop-font-lock-keywords
=>    '(;; var=val
        ("^[ \t]*\\(.+?\\)\\(?:\\.\\([0-9]+\\)\\(?:\\.\\(.+?\\)\\(?:\\.\\([0-9]+\\)\\(?:\\.\\(.+?\\)\\(?:\\.\\([0-9]+\\)\\(\\..+?\\)?\\)?\\)?\\)?\\)?\\)?\\([:= \t]\\|$\\)"
         (1 'font-lock-variable-name-face)
         (2 'font-lock-constant-face nil t)
         (3 'font-lock-variable-name-face nil t)
         (4 'font-lock-constant-face nil t)
         (5 'font-lock-variable-name-face nil t)
         (6 'font-lock-constant-face nil t)
         (7 'font-lock-variable-name-face nil t)))
      "Keywords to hilight in Conf Java Properties mode.")
    ...

Perhaps the conf-font-lock-keywords should also use single quote?

-- System Information
Debian Release: squeeze/sid
  APT Prefers testing
  APT policy: (990, testing) (500, unstable) (1, experimental)
Architecture: amd64
Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Fri Sep 17 21:50:19 UTC 2010 x86_64 GNU/Linux
Locale: LANG=en_DK.UTF-8

-- Versions of packages `emacs depends on'.
Depends:
emacs23         23.2+1-5.1      GNU Emacs is the extensible self-documenting 
emacs23-lucid   23.2+1-5.1      GNU Emacs is the extensible self-documenting 
emacs23-nox     23.2+1-5.1      GNU Emacs is the extensible self-documenting 





             reply	other threads:[~2010-12-22 19:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-22 19:01 Jari Aalto [this message]
2010-12-29 11:02 ` bug#7712: lisp/textmodes/conf-mode.el - Unused macro expansion in conf-font-lock-keywords Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vd2lvdgv.fsf@picasso.cante.net \
    --to=jari.aalto@cante.net \
    --cc=7712@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.