From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: patch-copy-dir-with-stefan-changes Date: Thu, 10 Feb 2011 09:38:47 +0100 Message-ID: <87vd0s8eso.fsf@gmx.de> References: <87mxm7wnk2.fsf@gmail.com> <87mxm7c9ut.fsf@gmail.com> <87r5bh2sf8.fsf@gmail.com> <871v3hgkid.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297327159 27095 80.91.229.12 (10 Feb 2011 08:39:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 10 Feb 2011 08:39:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 10 09:39:08 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PnS3O-0002tl-HA for ged-emacs-devel@m.gmane.org; Thu, 10 Feb 2011 09:39:06 +0100 Original-Received: from localhost ([127.0.0.1]:58862 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnS3S-0003yE-I6 for ged-emacs-devel@m.gmane.org; Thu, 10 Feb 2011 03:39:10 -0500 Original-Received: from [140.186.70.92] (port=46823 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnS3J-0003xX-J0 for emacs-devel@gnu.org; Thu, 10 Feb 2011 03:39:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PnS3D-0006zm-Sv for emacs-devel@gnu.org; Thu, 10 Feb 2011 03:38:56 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:49213) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PnS3D-0006zW-HD for emacs-devel@gnu.org; Thu, 10 Feb 2011 03:38:55 -0500 Original-Received: (qmail invoked by alias); 10 Feb 2011 08:38:52 -0000 Original-Received: from p57BB90C1.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.144.193] by mail.gmx.net (mp067) with SMTP; 10 Feb 2011 09:38:52 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX19XbVYkq79X4S6fV6oTdegViaeJjgC6H6lW7slOua 0HceE4JhBmkatW In-Reply-To: <871v3hgkid.fsf@gmail.com> (Thierry Volpiatto's message of "Wed, 09 Feb 2011 18:55:54 +0100") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.23 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135834 Archived-At: Thierry Volpiatto writes: > Stefan Monnier writes: > >>> here another approach to fix copy-directory and dired. >> >> Looks good. >> >> I'm not sure how it can get away with removing dired-do-create-files >> without removing any call to it, > OOPS! Of course we need it! It wouldn't work without it. > I remove it in the patch by error, sorry. For what I can tell, this patch looks pretty good. I've tested all three scenarios Thierry has explained in a previous mail, and I've tested it with local directories as well as with Tramp's ssh and rsync methods. All results are as expected. I vote for installing the patch into the emacs-23 branch. Best regards, Michael.