From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#9175: [PATCH] 24.0.50: Images colors on NextStep do not default correctly Date: Thu, 28 Jul 2011 14:29:19 -0400 Message-ID: <87vcuml0n4.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1311877818 10200 80.91.229.12 (28 Jul 2011 18:30:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 28 Jul 2011 18:30:18 +0000 (UTC) Cc: 9175@debbugs.gnu.org To: Alp Aker Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 28 20:30:14 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QmVLY-0007qB-Gp for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Jul 2011 20:30:12 +0200 Original-Received: from localhost ([::1]:60167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmVLY-00051m-1R for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Jul 2011 14:30:12 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:47836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmVLR-0004zM-Jy for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2011 14:30:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QmVLQ-0000Kt-M8 for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2011 14:30:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QmVLQ-0000Ko-ID for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2011 14:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QmVLO-0002Xo-MB; Thu, 28 Jul 2011 14:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Jul 2011 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9175 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 9175-submit@debbugs.gnu.org id=B9175.13118777649700 (code B ref 9175); Thu, 28 Jul 2011 18:30:02 +0000 Original-Received: (at 9175) by debbugs.gnu.org; 28 Jul 2011 18:29:24 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QmVKl-0002WO-A0 for submit@debbugs.gnu.org; Thu, 28 Jul 2011 14:29:23 -0400 Original-Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QmVKj-0002WF-6r for 9175@debbugs.gnu.org; Thu, 28 Jul 2011 14:29:21 -0400 Original-Received: from furball ([128.36.14.95]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p6SITK29017195 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 28 Jul 2011 14:29:20 -0400 In-Reply-To: (Alp Aker's message of "Tue, 26 Jul 2011 14:44:17 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 28 Jul 2011 14:30:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:49670 Archived-At: Alp Aker writes: > Image types that support :foreground and :background keywords in their > image descriptors are supposed to default to the frame foreground and > background colors when the relevant colors aren't specified. On NS, > however, these default to black. An easy test case is provided by > visiting a mono PBM image file (such as etc/images/splash.pbm) in > image-mode; what one will see is simply a black square. > > Diagnostic: The image loading functions in image.c take the default > colors from the frame's foreground_pixel and background_pixel fields, > but on NS the relevant frame parameter handlers don't set those > fields. The following patch corrects that. Thanks, applied.