From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Date: Thu, 18 Aug 2011 14:46:25 +0300 Organization: JURTA Message-ID: <87vctv54dq.fsf@mail.jurta.org> References: <87ljbyt7jg.fsf@jidanni.org> <871uwt38q1.fsf@mail.jurta.org> <87ippvhm3g.fsf@mail.jurta.org> <87y5yrwwj9.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1313668394 1590 80.91.229.12 (18 Aug 2011 11:53:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 18 Aug 2011 11:53:14 +0000 (UTC) Cc: 6117@debbugs.gnu.org, 'Lars Magne Ingebrigtsen' , jidanni@jidanni.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 18 13:53:09 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qu19p-0001f1-72 for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Aug 2011 13:53:09 +0200 Original-Received: from localhost ([::1]:42533 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qu19o-0008Pv-R7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Aug 2011 07:53:08 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:37588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qu19k-0008Kv-OR for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2011 07:53:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qu19j-0004i6-Ne for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2011 07:53:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qu19j-0004i1-Lw for bug-gnu-emacs@gnu.org; Thu, 18 Aug 2011 07:53:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Qu1Be-0006HI-6m; Thu, 18 Aug 2011 07:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Aug 2011 11:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.131366845324054 (code B ref 6117); Thu, 18 Aug 2011 11:55:02 +0000 Original-Received: (at 6117) by debbugs.gnu.org; 18 Aug 2011 11:54:13 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qu1Aq-0006Ft-GC for submit@debbugs.gnu.org; Thu, 18 Aug 2011 07:54:13 -0400 Original-Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qu1An-0006Fk-PY for 6117@debbugs.gnu.org; Thu, 18 Aug 2011 07:54:11 -0400 Original-Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 16E2C6E8053; Thu, 18 Aug 2011 04:52:10 -0700 (PDT) Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7B9FA451C3C3; Thu, 18 Aug 2011 04:52:08 -0700 (PDT) In-Reply-To: <87y5yrwwj9.fsf@stupidchicken.com> (Chong Yidong's message of "Wed, 17 Aug 2011 17:36:10 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 18 Aug 2011 07:55:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50126 Archived-At: > Looks fine to me, but test the 16-color versions of those faces in an > xterm first, to see if those color values give the right results. Done. I tested the 16-color versions in an xterm, and they look fine on light and dark backgrounds. I'm also going to install changes in packages related to dired that use faces for marked/flagged for deletion: === modified file 'lisp/ibuffer.el' --- lisp/ibuffer.el 2011-08-15 10:21:47 +0000 +++ lisp/ibuffer.el 2011-08-18 11:20:35 +0000 @@ -356,12 +356,12 @@ (defcustom ibuffer-load-hook nil :type 'hook :group 'ibuffer) -(defcustom ibuffer-marked-face 'font-lock-warning-face +(defcustom ibuffer-marked-face 'warning "Face used for displaying marked buffers." :type 'face :group 'ibuffer) -(defcustom ibuffer-deletion-face 'font-lock-type-face +(defcustom ibuffer-deletion-face 'error "Face used for displaying buffers marked for deletion." :type 'face :group 'ibuffer) === modified file 'lisp/proced.el' --- lisp/proced.el 2011-07-20 09:53:51 +0000 +++ lisp/proced.el 2011-08-18 11:29:33 +0000 @@ -395,7 +395,7 @@ (defface proced-mark :group 'proced-faces) (defface proced-marked - '((t (:inherit font-lock-warning-face))) + '((t (:inherit error))) "Face used for marked processes." :group 'proced-faces) === modified file 'lisp/battery.el' --- lisp/battery.el 2011-06-27 08:04:55 +0000 +++ lisp/battery.el 2011-08-18 11:12:33 +0000 @@ -199,7 +199,7 @@ (defun battery-update () 'face (and (<= (car (read-from-string (cdr (assq ?p data)))) battery-load-critical) - 'font-lock-warning-face) + 'error) 'help-echo "Battery status information"))) (force-mode-line-update))