From: Juri Linkov <juri@jurta.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: emacs-devel@gnu.org
Subject: Re: isearch.el patch for `M-e' to put point at mismatch position
Date: Sat, 10 Sep 2011 14:54:37 +0300 [thread overview]
Message-ID: <87vct1zh4q.fsf@mail.jurta.org> (raw)
In-Reply-To: <79A3EFE6965F48DC99409B8AC2363D2A@us.oracle.com> (Drew Adams's message of "Mon, 16 May 2011 14:36:39 -0700")
> The attached patch makes `M-e' (`isearch-edit-string') put point at the first
> mismatch position (or the search-string end if no mismatch).
>
> When you hit `M-e' you are ready to edit at the mismatch position. This makes
> it easy to change or insert a char or two to make the string match. (`C-g', on
> the other hand just removes all of the mismatch.)
>
> (This feature complements the use of highlighting to show users where the
> mismatch starts.)
>
> *** isearch.el Mon May 16 11:38:22 2011
> --- isearch-patched-2011-05-16.el Mon May 16 14:21:04 2011
> ***************
> *** 1060,1065 ****
> --- 1060,1080 ----
>
> (defvar minibuffer-history-symbol) ;; from external package gmhist.el
>
> + (defun isearch-fail-pos ()
> + "Position of first mismatch in search string, or its length if none."
> + (let ((cmds isearch-cmds)
> + succ-msg)
> + (if (and isearch-success (not isearch-error))
> + (length isearch-message)
> + (while (or (not (isearch-success-state (car cmds)))
> + (isearch-error-state (car cmds)))
> + (pop cmds))
> + (setq succ-msg (and cmds (isearch-message-state (car cmds))))
> + (if (and (stringp succ-msg) (< (length succ-msg) (length isearch-message))
> + (equal succ-msg (substring isearch-message 0 (length succ-msg))))
> + (length succ-msg)
> + 0))))
> +
> (defun isearch-edit-string ()
> "Edit the search string in the minibuffer.
> The following additional command keys are active while editing.
> ***************
> *** 1139,1145 ****
> (setq isearch-new-string
> (read-from-minibuffer
> (isearch-message-prefix nil nil isearch-nonincremental)
> ! isearch-string
> minibuffer-local-isearch-map nil
> (if isearch-regexp
> (cons 'regexp-search-ring
> --- 1154,1160 ----
> (setq isearch-new-string
> (read-from-minibuffer
> (isearch-message-prefix nil nil isearch-nonincremental)
> ! (cons isearch-string (1+ (isearch-fail-pos)))
I discovered now that you can't mix `isearch-message' and `isearch-string'.
Test case to reproduce the bug:
1. emacs -Q
2. insert a few TABs with e.g. `C-q TAB C-q TAB C-q TAB'
3. `M-<' (`beginning-of-buffer')
4. `C-s C-q TAB M-e'
fails with the error message "End of buffer".
The reason is that `isearch-message' is longer than `isearch-string',
because `isearch-text-char-description' replaces a single TAB
with two characters "^I" in `isearch-message'.
`isearch-fail-pos' calculates the position based on `isearch-message', but
uses it for `isearch-string' in `(cons isearch-string (1+ (isearch-fail-pos)))'
in `isearch-edit-string'.
Replacing `isearch-message' with `isearch-string' in `isearch-fail-pos'
will fix this bug.
BTW, there is exactly the same algorithm used in two functions
`isearch-fail-pos' and `isearch-message'. Currently both functions
use the same variable `isearch-message', but after this fix the same algorithm
will use different variables `isearch-message' and `isearch-string'.
So sharing code between them will be more difficult.
Maybe it would be better to add a new argument to `isearch-fail-pos'
that will define whether it should return the failed position in
`isearch-message' or `isearch-string'?
next prev parent reply other threads:[~2011-09-10 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 21:36 isearch.el patch for `M-e' to put point at mismatch position Drew Adams
2011-05-16 22:14 ` Juri Linkov
2011-05-16 22:37 ` Drew Adams
2011-05-17 3:08 ` Stefan Monnier
2011-05-27 20:54 ` Drew Adams
2011-05-28 1:27 ` Stefan Monnier
2011-09-10 11:54 ` Juri Linkov [this message]
2011-09-10 16:13 ` Drew Adams
2011-09-10 16:22 ` Drew Adams
2011-09-12 11:28 ` Juri Linkov
2011-09-12 14:58 ` Drew Adams
2011-09-14 16:08 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vct1zh4q.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.