From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: Patch to bookmark.el Date: Tue, 20 Dec 2011 13:11:13 -0500 Message-ID: <87vcpbi05a.fsf@kwarm.red-bean.com> References: <87zkeqhod2.fsf@floss.red-bean.com> <87pqfmcupi.fsf@floss.red-bean.com> <1324329297.5507.12.camel@localhost.localdomain> Reply-To: Karl Fogel NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1324404690 32070 80.91.229.12 (20 Dec 2011 18:11:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 20 Dec 2011 18:11:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: Matthias Meulien Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 20 19:11:25 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rd49t-00055v-8r for ged-emacs-devel@m.gmane.org; Tue, 20 Dec 2011 19:11:25 +0100 Original-Received: from localhost ([::1]:40199 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rd49s-0005qY-BM for ged-emacs-devel@m.gmane.org; Tue, 20 Dec 2011 13:11:24 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:33647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rd49o-0005pc-Cc for emacs-devel@gnu.org; Tue, 20 Dec 2011 13:11:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rd49n-0001ix-1g for emacs-devel@gnu.org; Tue, 20 Dec 2011 13:11:20 -0500 Original-Received: from mail-qw0-f48.google.com ([209.85.216.48]:46511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rd49m-0001ir-Ve for emacs-devel@gnu.org; Tue, 20 Dec 2011 13:11:19 -0500 Original-Received: by qadc16 with SMTP id c16so4609964qad.0 for ; Tue, 20 Dec 2011 10:11:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=0hr+SJHfPNVA2S/IA5Cyvx3ISASSbWoc6kXQP6TPVVk=; b=lml1w4xbQwvL4U6GcZ8ltRVZg3RDtJuTZrd973X/AadgiEHfvx09Q7Y6Nm6Gm7HuUz gBK8NwWcaCTgrGzTpGIeE2GJvjfnCy8oU6r1LS/l+TlNH4/EBUWc5NOGghfNOJZN5DPx LF730Ycfa8IZrYLe7mDuPRTt+W1JM4mzkxAv8= Original-Received: by 10.224.9.201 with SMTP id m9mr4180653qam.92.1324404677996; Tue, 20 Dec 2011 10:11:17 -0800 (PST) Original-Received: from kwarm.red-bean.com (topp148-office-nyc.openplans.org. [67.221.177.15]) by mx.google.com with ESMTPS id ih18sm2992009qab.8.2011.12.20.10.11.14 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 20 Dec 2011 10:11:15 -0800 (PST) In-Reply-To: <1324329297.5507.12.camel@localhost.localdomain> (Matthias Meulien's message of "Mon, 19 Dec 2011 22:14:57 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.216.48 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146882 Archived-At: Matthias Meulien writes: >I just tested the patch you sent to emacs-devel@gnu.org and realized it >is not based on the last version I sent to you: After applying your Sorry -- I don't know what happend, but I only ever got one version from you (as far as I know), which is the one my patch was based on. But anyway, see below... >patch, I still have a > > (forward-line 2) > >in function `bookmark-bmenu-show-filenames'. With this patch, file names >are not shown in the first two lines of the bookmark list (after calling >`bookmark-bmenu-toggle-file-names'). > >It should be replaced by something like: > > (when bookmark-bmenu-use-header-line > (bookmark-bmenu-set-header) > (forward-line bookmark-bmenu-header-height)) > >By the way, I have also a version of bookmark.el which adds dedicated >faces for buffer names and file paths like in the buffer list. If people >are interested I can send the corresponding patch to emacs-devel... Sounds good. For the sake of organization, let's do things this way: For your original patch, can you please regenerate the entire patch against the latest bookmark.el... http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/lisp/bookmark.el (click the "download file" button) ...and post it here, incorporating tweaks from my revised patch as appropriate, and including a log message similarly to the one I recently posted? Unified diff format ("diff -u") is best. Then we can do review right here. And as for the dedicated-faces patch, yes, thanks, we'd love to see it posted here too! Also generated against the latest pristine bookmark.el and with a log message. But let's keep the two patches separate, to make review simpler. Best, -Karl