From: Karl Fogel <kfogel@red-bean.com>
To: Matthias Meulien <orontee@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Patch to bookmark.el
Date: Tue, 20 Dec 2011 13:11:13 -0500 [thread overview]
Message-ID: <87vcpbi05a.fsf@kwarm.red-bean.com> (raw)
In-Reply-To: <1324329297.5507.12.camel@localhost.localdomain> (Matthias Meulien's message of "Mon, 19 Dec 2011 22:14:57 +0100")
Matthias Meulien <orontee@gmail.com> writes:
>I just tested the patch you sent to emacs-devel@gnu.org and realized it
>is not based on the last version I sent to you: After applying your
Sorry -- I don't know what happend, but I only ever got one version from
you (as far as I know), which is the one my patch was based on. But
anyway, see below...
>patch, I still have a
>
> (forward-line 2)
>
>in function `bookmark-bmenu-show-filenames'. With this patch, file names
>are not shown in the first two lines of the bookmark list (after calling
>`bookmark-bmenu-toggle-file-names').
>
>It should be replaced by something like:
>
> (when bookmark-bmenu-use-header-line
> (bookmark-bmenu-set-header)
> (forward-line bookmark-bmenu-header-height))
>
>By the way, I have also a version of bookmark.el which adds dedicated
>faces for buffer names and file paths like in the buffer list. If people
>are interested I can send the corresponding patch to emacs-devel...
Sounds good. For the sake of organization, let's do things this way:
For your original patch, can you please regenerate the entire patch
against the latest bookmark.el...
http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/lisp/bookmark.el
(click the "download file" button)
...and post it here, incorporating tweaks from my revised patch as
appropriate, and including a log message similarly to the one I recently
posted? Unified diff format ("diff -u") is best. Then we can do review
right here.
And as for the dedicated-faces patch, yes, thanks, we'd love to see it
posted here too! Also generated against the latest pristine bookmark.el
and with a log message. But let's keep the two patches separate, to
make review simpler.
Best,
-Karl
next prev parent reply other threads:[~2011-12-20 18:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAFEQCfBwuU54R4+dcDC4qHzX4gRrtA4yAhExDzot0iq9anvg1w@mail.gmail.com>
2011-12-17 21:36 ` Patch to bookmark.el Karl Fogel
2011-12-17 22:22 ` Stefan Monnier
2011-12-17 22:23 ` Karl Fogel
2011-12-19 19:30 ` Glenn Morris
2011-12-19 21:16 ` Matthias Meulien
2011-12-19 21:25 ` Glenn Morris
2011-12-18 5:30 ` Karl Fogel
2011-12-19 21:14 ` Matthias Meulien
2011-12-20 18:11 ` Karl Fogel [this message]
2011-12-20 23:03 ` Matthias Meulien
2011-12-20 23:29 ` Karl Fogel
2013-03-07 15:37 ` Matthias Meulien
2013-03-07 22:37 ` Karl Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcpbi05a.fsf@kwarm.red-bean.com \
--to=kfogel@red-bean.com \
--cc=emacs-devel@gnu.org \
--cc=orontee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.