From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#11381: 23.3; isearch-search-and-update issue? Date: Thu, 17 May 2012 03:08:33 +0300 Organization: JURTA Message-ID: <87vcjvwtxa.fsf@mail.jurta.org> References: <4F9DC154.2000605@groveronline.com> <87ipgggtmw.fsf@mail.jurta.org> <878vhcc4nl.fsf@mail.jurta.org> <87vcjxdt5p.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1337213522 24736 80.91.229.3 (17 May 2012 00:12:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 May 2012 00:12:02 +0000 (UTC) Cc: 11381@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 17 02:12:01 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SUoJw-0005gs-FC for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 May 2012 02:11:56 +0200 Original-Received: from localhost ([::1]:56197 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUoJv-0003V2-IU for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 May 2012 20:11:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUoJr-0003Uk-RF for bug-gnu-emacs@gnu.org; Wed, 16 May 2012 20:11:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUoJq-0004OJ-5Q for bug-gnu-emacs@gnu.org; Wed, 16 May 2012 20:11:51 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUoJq-0004OA-1k for bug-gnu-emacs@gnu.org; Wed, 16 May 2012 20:11:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SUoK1-0001ZU-LJ for bug-gnu-emacs@gnu.org; Wed, 16 May 2012 20:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 May 2012 00:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11381 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11381-submit@debbugs.gnu.org id=B11381.13372134665973 (code B ref 11381); Thu, 17 May 2012 00:12:01 +0000 Original-Received: (at 11381) by debbugs.gnu.org; 17 May 2012 00:11:06 +0000 Original-Received: from localhost ([127.0.0.1]:58281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUoJ2-0001Xp-Ri for submit@debbugs.gnu.org; Wed, 16 May 2012 20:11:02 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:58487 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUoIi-0001XF-Qt for 11381@debbugs.gnu.org; Wed, 16 May 2012 20:11:00 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 9AC3A451C8E3; Wed, 16 May 2012 17:10:26 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Tue, 15 May 2012 22:35:48 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60092 Archived-At: >> Below is a complete patch that moves them to Elisp: > > Feel free to install it on the trunk, thanks, Installed. Regarding the addition of symbol search functions, I hesitate to define 7 more functions for every search type. If now add symbol-search-forward, symbol-search-backward, symbol-search-forward-lax, symbol-search-backward-lax, and two functions to activate the symbol search isearch-forward-symbol, isearch-backward-symbol, then later someone might ask to add a subword search type with subword-search-forward, subword-search-backward, subword-search-forward-lax, subword-search-backward-lax, isearch-forward-subword, isearch-backward-subword, and so on. This will grow isearch.el unnecessarily. When trying to achieve simplicity, all what is needed to define for every regexp-based search type is just: 1. Define a string-to-regexp conversion function (like `word-search-regexp'). 2. Define a key sequence to activate this search type. This is a minimal set of requirements to define a new regexp-based search type. I believe a set of search filters for bug#11378 could be defined in the same simple way: 1. Define a filter predicate function (like `isearch-filter-visible'). 2. Define a key sequence to activate this search filter.