* Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame.
[not found] <E1SyGcw-0007JR-F1@vcs.savannah.gnu.org>
@ 2012-08-06 6:47 ` Bastien
2012-08-06 8:35 ` Dmitry Antipov
0 siblings, 1 reply; 10+ messages in thread
From: Bastien @ 2012-08-06 6:47 UTC (permalink / raw
To: Dmitry Antipov; +Cc: emacs-devel
Hi Dmitry,
Dmitry Antipov <dmantipov@yandex.ru> writes:
> ------------------------------------------------------------
> revno: 109456
> committer: Dmitry Antipov <dmantipov@yandex.ru>
> branch nick: trunk
> timestamp: Mon 2012-08-06 09:27:54 +0400
> message:
> Separate read and write access to Lisp_Object slots of struct frame.
> * frame.h (FGET, FSET): New macros similar to AREF and ASET.
> * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
> * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
> * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
> * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
This change completely breaks my Emacs. To reproduce:
emacs -Q
C-h v line-spacing RET
=> hangs forever, yells weird sounds, etc.
line-spacing is just an example here, any variable is fine.
--
Bastien
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame.
2012-08-06 6:47 ` /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame Bastien
@ 2012-08-06 8:35 ` Dmitry Antipov
2012-08-06 9:01 ` Andy Moreton
2012-08-06 9:47 ` Bastien
0 siblings, 2 replies; 10+ messages in thread
From: Dmitry Antipov @ 2012-08-06 8:35 UTC (permalink / raw
To: Bastien; +Cc: emacs-devel
On 08/06/2012 10:47 AM, Bastien wrote:
> This change completely breaks my Emacs. To reproduce:
>
> emacs -Q
> C-h v line-spacing RET
>
> => hangs forever, yells weird sounds, etc.
>
> line-spacing is just an example here, any variable is fine.
Argh, sorry for breaking the things. Should be fixed in 109463.
Dmitry
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame.
2012-08-06 8:35 ` Dmitry Antipov
@ 2012-08-06 9:01 ` Andy Moreton
2012-08-06 9:30 ` Dmitry Antipov
2012-08-06 9:47 ` Bastien
1 sibling, 1 reply; 10+ messages in thread
From: Andy Moreton @ 2012-08-06 9:01 UTC (permalink / raw
To: emacs-devel
On Mon 06 Aug 2012, Dmitry Antipov wrote:
> On 08/06/2012 10:47 AM, Bastien wrote:
>
>> This change completely breaks my Emacs. To reproduce:
>>
>> emacs -Q
>> C-h v line-spacing RET
>>
>> => hangs forever, yells weird sounds, etc.
>>
>> line-spacing is just an example here, any variable is fine.
>
> Argh, sorry for breaking the things. Should be fixed in 109463.
>
> Dmitry
Your changes in r109456 also broke the Windows build:
gcc -I. -c -gdwarf-2 -g3 -DEMACSDEBUG -fno-crossjumping -IC:/emacs/devel/libxml2-2.7.8/include/libxml2 -IC:/emacs/devel/gnutls-3.0.21/i nclude -IC:/emacs/devel/giflib-4.1.4-1/include -IC:/emacs/devel/jpeg-6b-4/include -IC:/emacs/devel/tiff-3.8.2-1/include -IC:/emacs/devel/ libpng-1.4.3-1/include -IC:/emacs/devel/xpm-3.5.1-1/include -IC:/emacs/devel/xpm-3.5.1-1/src/xpm/3.5.1/libXpm-3.5.1-src/lib -IC:/emacs/de vel/zlib-1.2.5-2/include -Demacs=1 -I../lib -I../nt/inc -DHAVE_NTGUI=1 -DUSE_CRT_DLL=1 -DPURESIZE=5000000 -o oo/i386/w32term.o w32term.c
w32term.c: In function 'x_frame_rehighlight':
w32term.c:2975:49: error: lvalue required as left operand of assignment
w32term.c: In function 'x_scroll_bar_create':
w32term.c:3647:3: error: lvalue required as left operand of assignment
w32term.c: In function 'w32_condemn_scroll_bars':
w32term.c:3832:33: error: lvalue required as left operand of assignment
w32term.c:3837:43: error: lvalue required as left operand of assignment
w32term.c: In function 'w32_redeem_scroll_bar':
w32term.c:3868:41: error: lvalue required as left operand of assignment
w32term.c:3882:3: error: lvalue required as left operand of assignment
w32term.c: In function 'w32_judge_scroll_bars':
w32term.c:3899:35: error: lvalue required as left operand of assignment
AndyM
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame.
2012-08-06 9:01 ` Andy Moreton
@ 2012-08-06 9:30 ` Dmitry Antipov
2012-08-06 12:37 ` Andy Moreton
0 siblings, 1 reply; 10+ messages in thread
From: Dmitry Antipov @ 2012-08-06 9:30 UTC (permalink / raw
To: Andy Moreton; +Cc: emacs-devel
On 08/06/2012 01:01 PM, Andy Moreton wrote:
> Your changes in r109456 also broke the Windows build:
These should be fixed in 109464.
Dmitry
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame.
2012-08-06 8:35 ` Dmitry Antipov
2012-08-06 9:01 ` Andy Moreton
@ 2012-08-06 9:47 ` Bastien
1 sibling, 0 replies; 10+ messages in thread
From: Bastien @ 2012-08-06 9:47 UTC (permalink / raw
To: Dmitry Antipov; +Cc: emacs-devel
Dmitry Antipov <dmantipov@yandex.ru> writes:
>> This change completely breaks my Emacs. To reproduce:
>>
>> emacs -Q
>> C-h v line-spacing RET
>>
>> => hangs forever, yells weird sounds, etc.
>>
>> line-spacing is just an example here, any variable is fine.
>
> Argh, sorry for breaking the things. Should be fixed in 109463.
I confirm the fix, thanks!
--
Bastien
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame.
2012-08-06 9:30 ` Dmitry Antipov
@ 2012-08-06 12:37 ` Andy Moreton
2012-08-06 15:47 ` Dmitry Antipov
0 siblings, 1 reply; 10+ messages in thread
From: Andy Moreton @ 2012-08-06 12:37 UTC (permalink / raw
To: emacs-devel
On Mon 06 Aug 2012, Dmitry Antipov wrote:
> On 08/06/2012 01:01 PM, Andy Moreton wrote:
>
>> Your changes in r109456 also broke the Windows build:
>
> These should be fixed in 109464.
>
> Dmitry
There is still a problem:
gcc -I. -c -gdwarf-2 -g3 -DEMACSDEBUG -fno-crossjumping
-IC:/emacs/devel/libxml2-2.7.8/include/libxml2
-IC:/emacs/devel/gnutls-3.0.21/include
-IC:/emacs/devel/giflib-4.1.4-1/include
-IC:/emacs/devel/jpeg-6b-4/include -IC:/emacs/devel/tiff-3.8.2-1/include
-IC:/emacs/devel/libpng-1.4.3-1/include
-IC:/emacs/devel/xpm-3.5.1-1/include
-IC:/emacs/devel/xpm-3.5.1-1/src/xpm/3.5.1/libXpm-3.5.1-src/lib
-IC:/emacs/devel/zlib-1.2.5-2/include -Demacs=1 -I../lib -I../nt/inc
-DHAVE_NTGUI=1 -DUSE_CRT_DLL=1 -o oo/i386/w32term.o w32term.c
w32term.c: In function 'w32_set_vertical_scroll_bar':
w32term.c:3810:3: error: lvalue required as left operand of assignment
AndyM
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame.
2012-08-06 12:37 ` Andy Moreton
@ 2012-08-06 15:47 ` Dmitry Antipov
2012-08-06 16:12 ` Juanma Barranquero
2012-08-06 16:42 ` Eli Zaretskii
0 siblings, 2 replies; 10+ messages in thread
From: Dmitry Antipov @ 2012-08-06 15:47 UTC (permalink / raw
To: Andy Moreton; +Cc: emacs-devel
On 08/06/2012 04:37 PM, Andy Moreton wrote:
> There is still a problem:
Should be fixed in 109469.
Dmitry
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame.
2012-08-06 15:47 ` Dmitry Antipov
@ 2012-08-06 16:12 ` Juanma Barranquero
2012-08-06 17:04 ` Eli Zaretskii
2012-08-06 16:42 ` Eli Zaretskii
1 sibling, 1 reply; 10+ messages in thread
From: Juanma Barranquero @ 2012-08-06 16:12 UTC (permalink / raw
To: Dmitry Antipov; +Cc: Andy Moreton, emacs-devel
On Mon, Aug 6, 2012 at 5:47 PM, Dmitry Antipov <dmantipov@yandex.ru> wrote:
> Should be fixed in 109469.
Not all:
w32menu.c: In function 'set_frame_menubar':
w32menu.c:416:32: error: lvalue required as left operand of assignment
w32menu.c:602:7: warning: implicit declaration of function
'x_set_window_size' [-Wimplicit-function-declaration]
w32menu.c: In function 'initialize_frame_menubar':
w32menu.c:618:28: error: lvalue required as left operand of assignment
make[1]: *** [oo-spd/i386/w32menu.o] Error 1
Juanma
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame.
2012-08-06 15:47 ` Dmitry Antipov
2012-08-06 16:12 ` Juanma Barranquero
@ 2012-08-06 16:42 ` Eli Zaretskii
1 sibling, 0 replies; 10+ messages in thread
From: Eli Zaretskii @ 2012-08-06 16:42 UTC (permalink / raw
To: Dmitry Antipov; +Cc: emacs-devel
This change in xmenu.c (and similar changes in nsmenu.m and w32menu.c
that followed suit):
- FRAME_MENU_BAR_ITEMS (f) = menu_bar_items (FRAME_MENU_BAR_ITEMS (f));
+ FSET (f, menu_bar_items, menu_bar_items (FRAME_MENU_BAR_ITEMS (f)));
exposed what was previously hidden behind the FRAME_MENU_BAR_ITEMS
macro. Should we introduce a FRAME_SET_MENU_BAR_ITEMS macro instead?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame.
2012-08-06 16:12 ` Juanma Barranquero
@ 2012-08-06 17:04 ` Eli Zaretskii
0 siblings, 0 replies; 10+ messages in thread
From: Eli Zaretskii @ 2012-08-06 17:04 UTC (permalink / raw
To: Juanma Barranquero; +Cc: dmantipov, andrewjmoreton, emacs-devel
> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Mon, 6 Aug 2012 18:12:24 +0200
> Cc: Andy Moreton <andrewjmoreton@gmail.com>, emacs-devel@gnu.org
>
> On Mon, Aug 6, 2012 at 5:47 PM, Dmitry Antipov <dmantipov@yandex.ru> wrote:
>
> > Should be fixed in 109469.
>
> Not all:
>
> w32menu.c: In function 'set_frame_menubar':
> w32menu.c:416:32: error: lvalue required as left operand of assignment
> w32menu.c:602:7: warning: implicit declaration of function
> 'x_set_window_size' [-Wimplicit-function-declaration]
> w32menu.c: In function 'initialize_frame_menubar':
> w32menu.c:618:28: error: lvalue required as left operand of assignment
> make[1]: *** [oo-spd/i386/w32menu.o] Error 1
Yes, I fixed that meanwhile.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-08-06 17:04 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1SyGcw-0007JR-F1@vcs.savannah.gnu.org>
2012-08-06 6:47 ` /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame Bastien
2012-08-06 8:35 ` Dmitry Antipov
2012-08-06 9:01 ` Andy Moreton
2012-08-06 9:30 ` Dmitry Antipov
2012-08-06 12:37 ` Andy Moreton
2012-08-06 15:47 ` Dmitry Antipov
2012-08-06 16:12 ` Juanma Barranquero
2012-08-06 17:04 ` Eli Zaretskii
2012-08-06 16:42 ` Eli Zaretskii
2012-08-06 9:47 ` Bastien
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.