From: Romain Francoise <romain@orebokech.com>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH v2] POSIX ACL support
Date: Thu, 06 Dec 2012 20:48:43 +0100 [thread overview]
Message-ID: <87vccfm06c.fsf@silenus.orebokech.com> (raw)
In-Reply-To: <w2vcch1bd7.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 04 Dec 2012 21:28:04 -0500")
Hi Glenn,
Glenn Morris <rgm@gnu.org> writes:
>> +The return value is a string containing the textual representation of
>> +the ACL entries.
> Maybe give an example?
Ok.
> Apart from those trivial comments, just needs a NEWS entry.
> Otherwise looks good to me...
Thanks for the review!
I'll add the NEWS and ChangeLog entries and then I can install it myself
to the trunk, but I think I need to get the go-ahead from Stefan and/or
Chong?
next prev parent reply other threads:[~2012-12-06 19:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 20:04 [PATCH v2] POSIX ACL support Romain Francoise
2012-12-04 20:42 ` Eli Zaretskii
2012-12-06 19:45 ` Romain Francoise
2012-12-07 8:19 ` Michael Albinus
2012-12-07 9:32 ` Eli Zaretskii
2012-12-05 2:28 ` Glenn Morris
2012-12-05 3:53 ` Eli Zaretskii
2012-12-05 4:09 ` Glenn Morris
2012-12-05 16:16 ` Eli Zaretskii
2012-12-05 17:18 ` Glenn Morris
2012-12-06 19:48 ` Romain Francoise [this message]
2012-12-06 21:33 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vccfm06c.fsf@silenus.orebokech.com \
--to=romain@orebokech.com \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.