Key binding to print VC root log from VC dir

Key binding to print VC root log from VC dir

[Matthias Meulien]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Severity: wishlist Tags: patch  From a buffer visiting a file 
under version control one has the following two key bindings to 
display logs:

          C-x v l runs the command vc-print-log

          C-x v L runs the command vc-print-root-log

From a buffer in `vc-dir-mode' one has the key binding:

          l runs the command vc-print-log

But there is no `vc-print-root-log' key binding...


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Key binding to print VC root log from VC dir --]
[-- Type: text/x-diff, Size: 886 bytes --]

From 58b23b29b45e2d3f17ed76e8ff010501d966d2c0 Mon Sep 17 00:00:00 2001
From: Matthias Meulien <orontee@gmail.com>
Date: Wed, 24 Jul 2013 23:39:51 +0200
Subject: [PATCH] lisp/vc/vc-dir.el (vc-dir-mode-map): Keybinding for
 vc-print-root-log

---
 lisp/vc/vc-dir.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
index 80f7849..325e66e 100644
--- a/lisp/vc/vc-dir.el
+++ b/lisp/vc/vc-dir.el
@@ -240,6 +240,7 @@ See `run-hooks'."
     (define-key map "i" 'vc-register)	   ;; C-x v i
     (define-key map "+" 'vc-update)	   ;; C-x v +
     (define-key map "l" 'vc-print-log)	   ;; C-x v l
+    (define-key map "L" 'vc-print-root-log) ;; C-x v L
     ;; More confusing than helpful, probably
     ;;(define-key map "R" 'vc-revert) ;; u is taken by vc-dir-unmark.
     ;;(define-key map "A" 'vc-annotate) ;; g is taken by revert-buffer
-- 
1.8.3.3


[-- Attachment #3: Type: text/plain, Size: 34 bytes --]


Thanks for reading,
-- 
Matthias

Re: Key binding to print VC root log from VC dir

[Glenn Morris]

Matthias Meulien wrote:

> Severity: wishlist Tags: patch  From a buffer visiting a file under

Thanks for the patches. Couple of FYIs:
Since the above items were not on separate lines, they had no effect.
Also, there is no need to send things to both emacs-devel and
bug-gnu-emacs.

bug#14948: Key binding to print VC root log from VC dir

[Dmitry Gutov]

Matthias Meulien <orontee@gmail.com> writes:

> Severity: wishlist Tags: patch  From a buffer visiting a file under
> version control one has the following two key bindings to display
> logs:
>
>          C-x v l runs the command vc-print-log
>
>          C-x v L runs the command vc-print-root-log
>
> From a buffer in `vc-dir-mode' one has the key binding:
>
>          l runs the command vc-print-log
>
> But there is no `vc-print-root-log' key binding...

There is. It's a global one. `C-x v L' works for me in vc-dir-mode
buffers even without this patch.

What's the problem you're trying to solve?

bug#14948: Key binding to print VC root log from VC dir

[Stefan Monnier]

>> C-x v l runs the command vc-print-log
>> C-x v L runs the command vc-print-root-log
>> 
>> From a buffer in `vc-dir-mode' one has the key binding:
>> 
>> l runs the command vc-print-log
>> 
>> But there is no `vc-print-root-log' key binding...

> There is. It's a global one. `C-x v L' works for me in vc-dir-mode
> buffers even without this patch.

But since `C-x v l' is duplicated as `l', it makes a lot of sense to
duplicate `C-x v L' as `L' as his patch suggests.

Could someone install his patch, please?


        Stefan

Re: bug#14948: Key binding to print VC root log from VC dir

[Stefan Monnier]

>> C-x v l runs the command vc-print-log
>> C-x v L runs the command vc-print-root-log
>> 
>> From a buffer in `vc-dir-mode' one has the key binding:
>> 
>> l runs the command vc-print-log
>> 
>> But there is no `vc-print-root-log' key binding...

> There is. It's a global one. `C-x v L' works for me in vc-dir-mode
> buffers even without this patch.

But since `C-x v l' is duplicated as `l', it makes a lot of sense to
duplicate `C-x v L' as `L' as his patch suggests.

Could someone install his patch, please?


        Stefan

bug#14948: Key binding to print VC root log from VC dir

[Juanma Barranquero]

On Fri, Jul 26, 2013 at 9:53 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:

> Could someone install his patch, please?

Done as revno:113554

Re: bug#14948: Key binding to print VC root log from VC dir

[Juanma Barranquero]

On Fri, Jul 26, 2013 at 9:53 AM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:

> Could someone install his patch, please?

Done as revno:113554

Re: Key binding to print VC root log from VC dir

[Matthias Meulien]

> (...) FYIs:
> Since the above items were not on separate lines, they had no effect.
> Also, there is no need to send things to both emacs-devel and
> bug-gnu-emacs.

Thanks, I'll take care.
-- 
Matthias

bug#14948: Key binding to print VC root log from VC dir

[Dmitry Gutov]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> But since `C-x v l' is duplicated as `l', it makes a lot of sense to
> duplicate `C-x v L' as `L' as his patch suggests.

I see.
Shall we add a similar 'D' binding for `vc-root-diff'?

Re: bug#14948: Key binding to print VC root log from VC dir

[Dmitry Gutov]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> But since `C-x v l' is duplicated as `l', it makes a lot of sense to
> duplicate `C-x v L' as `L' as his patch suggests.

I see.
Shall we add a similar 'D' binding for `vc-root-diff'?

bug#14948: Key binding to print VC root log from VC dir

[Stefan Monnier]

>> But since `C-x v l' is duplicated as `l', it makes a lot of sense to
>> duplicate `C-x v L' as `L' as his patch suggests.
> I see.
> Shall we add a similar 'D' binding for `vc-root-diff'?

That would make sense.


        Stefan

Re: bug#14948: Key binding to print VC root log from VC dir

[Stefan Monnier]

>> But since `C-x v l' is duplicated as `l', it makes a lot of sense to
>> duplicate `C-x v L' as `L' as his patch suggests.
> I see.
> Shall we add a similar 'D' binding for `vc-root-diff'?

That would make sense.


        Stefan

bug#14948: Key binding to print VC root log from VC dir

[Xue Fuqiao]

Done as revision 113563, thanks.

--
Best regards, Xue Fuqiao.

bug#14948: Key binding to print VC root log from VC dir

[Dmitry Gutov]

Xue Fuqiao <xfq.free@gmail.com> writes:

> Done as revision 113563, thanks.

Thank you. It has actually been a "paper cut" bug for me for a while.