all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: 16197@debbugs.gnu.org
Subject: bug#16197: 24.3.50; no completion on commands following "sudo" in shell and eshell
Date: Mon, 23 Dec 2013 11:21:59 +0100	[thread overview]
Message-ID: <87vbyfoojc.fsf@gmail.com> (raw)
In-Reply-To: <87fvpolyuk.fsf@gmail.com>

Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:

> With this I have completion on arguments of commands entered after
> "sudo" (only in eshell though, not shell for the moment) and emacs is
> not crashing when hitting TAB.

Now I have the completion in shell also, for this
`shell-command-completion' have to be redefined.

--8<---------------cut here---------------start------------->8---
(defun shell-command-completion ()
  "Return the completion data for the command at point, if any."
  (let ((filename (comint-match-partial-filename))
        (args (split-string
               (buffer-substring-no-properties
                (point) (save-excursion (shell-backward-command 1) (point))))))
    (if (and filename
             (save-match-data (not (string-match "[~/]" filename)))
             (and (string= (car args) "sudo")
                  (string= filename (cadr args))))
        (shell--command-completion-data))))
--8<---------------cut here---------------end--------------->8---

HTH, though the crash happening above should not happen.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 






  reply	other threads:[~2013-12-23 10:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-20  8:18 bug#16197: 24.3.50; no completion on commands following "sudo" in shell and eshell Thierry Volpiatto
2013-12-23  8:36 ` Thierry Volpiatto
2013-12-23 10:21   ` Thierry Volpiatto [this message]
2013-12-24  6:59     ` Thierry Volpiatto
2013-12-24 10:49       ` Thierry Volpiatto
2014-01-03 22:53         ` Stefan Monnier
2014-01-04  5:33           ` Thierry Volpiatto
2014-01-04  7:11             ` Thierry Volpiatto
2014-01-04 20:26             ` Stefan Monnier
2014-01-05  7:35               ` Thierry Volpiatto
2020-09-25 17:51                 ` Stefan Monnier
2020-09-26 13:09                   ` Lars Ingebrigtsen
2020-09-26 22:17                     ` Stefan Monnier
2020-09-27 12:08                       ` Lars Ingebrigtsen
2020-09-28  2:07                         ` Stefan Monnier
2020-09-28 11:12                           ` Lars Ingebrigtsen
2014-01-07 13:11               ` Thierry Volpiatto
2020-09-25 10:44                 ` Lars Ingebrigtsen
2014-01-07 15:26               ` Thierry Volpiatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbyfoojc.fsf@gmail.com \
    --to=thierry.volpiatto@gmail.com \
    --cc=16197@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.