org-cycle-hook from org-mode hook

org-cycle-hook from org-mode hook

[François Pinard]

Hi again, Org people.

I noticed a recent change in Org mode behaviour, which I guess is
related to a "git pull" of the org-mode project.  This is so minor that
it is hardly a problem for me, I only report it in case it would hint at
some unwanted change that would have more consequences for others.

Opening an Org file in Emacs executes the hooks on org-mode-hooks.
Previously, it also executed the hooks on org-cycle-hook, while now, I
have the impression it does not anymore.  The solution is easy for me, I
merely run my own Org cycle hook function from my main Org mode hook.

François

Re: org-cycle-hook from org-mode hook

[Bastien]

Hi François,

François Pinard <pinard@iro.umontreal.ca> writes:

> I noticed a recent change in Org mode behaviour, which I guess is
> related to a "git pull" of the org-mode project.  This is so minor that
> it is hardly a problem for me, I only report it in case it would hint at
> some unwanted change that would have more consequences for others.

Thanks for reporting this.

The commit introducing the change must be this one:
http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=44acd000

> Opening an Org file in Emacs executes the hooks on org-mode-hooks.
> Previously, it also executed the hooks on org-cycle-hook, while now, I
> have the impression it does not anymore.  The solution is easy for me, I
> merely run my own Org cycle hook function from my main Org mode hook.

The function `org-set-startup-visibility' is always called when you
find an Org file interactively.  Previously, it used `org-cycle'
internally to set the visibility state.  Now it uses `org-content`
and `org-overview' instead, so that C-u C-u TAB always work.

I think it makes sense to call org-cycle-hooks *only* when cycling
manually, so the current behavior makes sense IMO.  Let me know if
you (or others) think otherwise.

-- 
 Bastien

Re: org-cycle-hook from org-mode hook

[François Pinard]

Bastien <bzg@gnu.org> writes:

> Now it uses `org-content` and `org-overview' instead, so that C-u C-u
> TAB always work.

I did not immediately find the documentation about C-u C-u TAB, which is
in the node "Initial visibility".  The node "Global and local cycling"
documents TAB, C-u TAB and C-u C-u C-u TAB, but surprisingly, not C-u
C-u TAB.  Maybe some linking between those two manual nodes would be
useful to other users, when they happen to be as anal as I am? :-)

François

P.S. "anal" in the Piagetian meaning of the word, of course!  People
suffering from anal disorder are either ultra-meticulous, or completely
disorganized.  Most of the time, I see myself as being from the former
species, yet some days, I confess, I feel like I am from the later.

Re: org-cycle-hook from org-mode hook

[Bastien]

François Pinard <pinard@iro.umontreal.ca> writes:

> I did not immediately find the documentation about C-u C-u TAB, which is
> in the node "Initial visibility".  The node "Global and local cycling"
> documents TAB, C-u TAB and C-u C-u C-u TAB, but surprisingly, not C-u
> C-u TAB.  Maybe some linking between those two manual nodes would be
> useful to other users, when they happen to be as anal as I am? :-)

Yes, I added the information and the link, thanks!

-- 
 Bastien

Re: org-cycle-hook from org-mode hook

[Eric S Fraga]

François Pinard <pinard@iro.umontreal.ca> writes:

[...]

> P.S. "anal" in the Piagetian meaning of the word, of course!  People
> suffering from anal disorder are either ultra-meticulous, or completely
> disorganized.  Most of the time, I see myself as being from the former
> species, yet some days, I confess, I feel like I am from the later.

:)

In my case, I find myself exhibiting the former trait due to the latter
reality... luckily org is here to not only help me be less disorganised
but also more meticulous!
-- 
: Eric S Fraga (0xFFFCF67D), Emacs 24.3.1, Org release_8.2.4-322-gece429