From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Richard Newsgroups: gmane.emacs.bugs Subject: bug#16935: 24.3.50; when tab-completing in 'M-x' : "Wrong type argument: numberp, nil" Date: Tue, 04 Mar 2014 16:03:15 +0100 Message-ID: <87vbvuxaz0.fsf@yahoo.fr> References: <871tyiyrvp.fsf@yahoo.fr> <87mwh62fkq.fsf@bzg.ath.cx> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1393945452 23793 80.91.229.3 (4 Mar 2014 15:04:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Mar 2014 15:04:12 +0000 (UTC) Cc: Nicolas Richard , Leo Liu , 16935@debbugs.gnu.org To: Bastien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 04 16:04:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WKqtG-00068X-Qv for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Mar 2014 16:04:18 +0100 Original-Received: from localhost ([::1]:45720 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKqtG-0000ua-8c for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Mar 2014 10:04:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKqt6-0000sp-SY for bug-gnu-emacs@gnu.org; Tue, 04 Mar 2014 10:04:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKqt0-0001tx-MG for bug-gnu-emacs@gnu.org; Tue, 04 Mar 2014 10:04:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKqt0-0001tl-IW for bug-gnu-emacs@gnu.org; Tue, 04 Mar 2014 10:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WKqsz-0003bC-NE for bug-gnu-emacs@gnu.org; Tue, 04 Mar 2014 10:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Mar 2014 15:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16935-submit@debbugs.gnu.org id=B16935.139394538513756 (code B ref 16935); Tue, 04 Mar 2014 15:04:01 +0000 Original-Received: (at 16935) by debbugs.gnu.org; 4 Mar 2014 15:03:05 +0000 Original-Received: from localhost ([127.0.0.1]:50471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WKqs5-0003Zo-6v for submit@debbugs.gnu.org; Tue, 04 Mar 2014 10:03:05 -0500 Original-Received: from mxin.ulb.ac.be ([164.15.128.112]:18326) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WKqs1-0003ZH-0q for 16935@debbugs.gnu.org; Tue, 04 Mar 2014 10:03:01 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ap4EAHzqFVOkD4Xx/2dsb2JhbABaxQeBM3SCJgEBBHkQCAMhJQ8BBA08E4dkAQMRrQ6YGQFKDYZcF4dYhGSCFQeEOASWT4FthjOGMIVIgW+BPzs Original-Received: from mathsrv4.ulb.ac.be (HELO geodiff-mac3) ([164.15.133.241]) by smtp.ulb.ac.be with ESMTP; 04 Mar 2014 16:02:56 +0100 In-Reply-To: <87mwh62fkq.fsf@bzg.ath.cx> (Bastien's message of "Tue, 04 Mar 2014 15:39:33 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86535 Archived-At: Bastien writes: > Leo Liu writes: >> I noticed this error too. (base-size (cdr last)) is used in 24.3 and no >> errors there. So it will be good to know where the problem originated >> and fix it. > The commit makes `base-size' optional, so we need to ensure it > falls back to 0 instead of nil. Shouldn't base-size default to 0 in completion-hilit-commonality then, to avoid having to fix code that relies on base-size being an integer everywhere else ? Or were all such occurrences found already ? --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -1595,11 +1595,12 @@ This adds the face `completions-common-part' to the first `completions-first-difference' to the first character after that. It returns a list with font-lock properties applied to each element, -and with BASE-SIZE appended as the last element." +and with BASE-SIZE (or zero) appended as the last element." + (or base-size (setq base-size 0)) (when completions (if (zerop prefix-len) completions - (let ((com-str-len (- prefix-len (or base-size 0)))) + (let ((com-str-len (- prefix-len base-size))) (nconc (mapcar (lambda (elem) -- Nico.