From: Juri Linkov <juri@jurta.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 17439@debbugs.gnu.org
Subject: bug#17439: 24.3.50; run-with-idle-timer runs on focus-out
Date: Sat, 10 May 2014 23:38:20 +0300 [thread overview]
Message-ID: <87vbtd5p6u.fsf@mail.jurta.org> (raw)
In-Reply-To: <83r442upj2.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 10 May 2014 09:16:33 +0300")
> So are you saying we should NOT ignore focus-in? If you still think
> focus-in should be ignored, then I think the above description
> (perhaps together with the window manager where it was observed)
> should be in the comments to the code.
After more testing without ignoring focus-in and with ignoring focus-out,
often pressing and releasing Alt-Tab quickly generates both events
focus-in and focus-out, and when having no time to show the Window List
focus-in moves the mouse pointer and hides the selected window.
So both events should be ignored, like `switch-frame' is already ignored
when switching between Emacs frames. I'll add a comment about this.
And there are more fixes necessary in avoid.el. This patch will ignore
modifiers used together with mouse events:
=== modified file 'lisp/avoid.el'
--- lisp/avoid.el 2014-01-01 07:43:34 +0000
+++ lisp/avoid.el 2014-05-10 20:36:19 +0000
@@ -347,7 +348,13 @@ (defun mouse-avoidance-ignore-p ()
(memq 'double modifiers)
(memq 'triple modifiers)
(memq 'drag modifiers)
- (memq 'down modifiers)))))))
+ (memq 'down modifiers)
+ (memq 'meta modifiers)
+ (memq 'control modifiers)
+ (memq 'shift modifiers)
+ (memq 'hyper modifiers)
+ (memq 'super modifiers)
+ (memq 'alt modifiers)))))))
(defun mouse-avoidance-banish ()
(if (not (mouse-avoidance-ignore-p))
And this patch fixes the customization of `mouse-avoidance-banish-position'
(it can be tested by e.g. using `set-variable' on `mouse-avoidance-banish-position'):
=== modified file 'lisp/avoid.el'
--- lisp/avoid.el 2014-01-01 07:43:34 +0000
+++ lisp/avoid.el 2014-05-10 20:36:19 +0000
@@ -129,9 +129,10 @@ (defcustom mouse-avoidance-banish-positi
TOP-OR-BOTTOM-POS: Distance from top or bottom edge of frame or window."
:group 'avoid
:version "24.3"
- :type '(alist :key-type symbol :value-type symbol)
- :options '(frame-or-window side (side-pos integer)
- top-or-bottom (top-or-bottom-pos integer)))
+ :type '(alist :key-type symbol :value-type (choice symbol integer))
+ :options '((frame-or-window symbol) (side symbol) (side-pos integer)
+ (top-or-bottom symbol) (top-or-bottom-pos integer)))
next prev parent reply other threads:[~2014-05-10 20:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 20:45 bug#17439: 24.3.50; run-with-idle-timer runs on focus-out Juri Linkov
2014-05-09 6:28 ` Eli Zaretskii
2014-05-09 20:35 ` Juri Linkov
2014-05-10 6:16 ` Eli Zaretskii
2014-05-10 20:38 ` Juri Linkov [this message]
2014-05-11 20:19 ` Juri Linkov
2014-05-11 21:06 ` Stefan Monnier
2014-05-11 21:31 ` Juri Linkov
2014-05-11 22:29 ` Stefan Monnier
2014-05-12 20:39 ` Juri Linkov
2014-05-13 19:33 ` Stefan Monnier
2014-05-20 21:14 ` Juri Linkov
2014-05-20 22:12 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbtd5p6u.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=17439@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.