bug#16255: C-h p C-s games RET (package-show-package-list?) misses most of the games

bug#16255: C-h p C-s games RET (package-show-package-list?) misses most of the games

[Ivan Shmakov]

Package:  emacs
Severity: minor

	As of 84b50168 [1], C-h p C-s games RET lists only a few games
	of those coming with Emacs:

  Package            Version      Status ▼   Archive    Description
  dunnet             2.1          built-in              text adventure for Emacs
  gamegrid           1.2          built-in              library for implementing grid-based games on Emacs
  tetris             2.1          built-in              implementation of Tetris for Emacs

[1] http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=84b50168

	As it seems, package-show-package-list is given all the games
	found, yet it fails to render them in the resulting *Packages*
	buffer, perhaps because of them missing the Version: metadata.

	As per M-x trace-function-background:

1 -> (package-show-package-list (zone tetris studly spook solitaire snake pong mpuz morse meese life landmark hanoi gomoku gametree gamegrid fortune dunnet doctor dissociate decipher cookie1 bubbles blackbox animate 5x5))
1 <- package-show-package-list: #<buffer *Packages*>

-- 
FSF associate member #7257

bug#16255: C-h p C-s games RET (package-show-package-list?) misses most of the games

[Stefan Monnier]

	As it seems, package-show-package-list is given all the games
	found, yet it fails to render them in the resulting *Packages*
	buffer, perhaps because of them missing the Version: metadata.

	As per M-x trace-function-background:

package.el was designed to handle installation of packages that are
separate from Emacs.   It can also deal with packages that are bundled
with Emacs, but only if those announce themselves as such.


        Stefan

bug#16255: C-h p C-s games RET (package-show-package-list?) misses most of the games

[Ivan Shmakov]

>>>>> Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

 >> As it seems, package-show-package-list is given all the games found,
 >> yet it fails to render them in the resulting *Packages* buffer,
 >> perhaps because of them missing the Version: metadata.

 >> As per M-x trace-function-background:

 > package.el was designed to handle installation of packages that are
 > separate from Emacs.  It can also deal with packages that are bundled
 > with Emacs, but only if those announce themselves as such.

	Well, just to be clear, C-h p C-s games RET RET results in the
	following list on Emacs 24.3.1.

  5x5                             built-in   simple little puzzle game
  animate                         built-in   make text dance
  blackbox                        built-in   blackbox game in Emacs Lisp
  bubbles                         built-in   Puzzle game for Emacs
  cookie1                         built-in   retrieve random phrases from fortune cookie files
  decipher                        built-in   cryptanalyze monoalphabetic substitution ciphers
  dissociate                      built-in   scramble text amusingly for Emacs
  doctor                          built-in   psychological help for frustrated users
  dunnet             2.1          built-in   text adventure for Emacs
  fortune                         built-in   use fortune to create signatures
  gamegrid           1.2          built-in   library for implementing grid-based games on Emacs
  gametree                        built-in   manage game analysis trees in Emacs
  gomoku                          built-in   Gomoku game between you and Emacs
  hanoi                           built-in   towers of hanoi in Emacs
  landmark                        built-in   neural-network robot that learns landmarks
  life                            built-in   John Horton Conway's `Life' game for GNU Emacs
  meese                           built-in   protect the impressionable young minds of America
  morse                           built-in   convert text to morse code and back
  mpuz                            built-in   multiplication puzzle for GNU Emacs
  pong                            built-in   classical implementation of pong
  snake                           built-in   implementation of Snake for Emacs
  solitaire                       built-in   game of solitaire in Emacs Lisp
  spook                           built-in   spook phrase utility for overloading the NSA line eater
  studly                          built-in   StudlyCaps (tm)(r)(c)(xxx)
  tetris             2.1          built-in   implementation of Tetris for Emacs
  yow                             built-in   quote random zippyisms
  zone                            built-in   idle display hacks

	To me, the failure of the recent development version to show the
	above seems like a regression, regardless of the particulars.

	If the change made to package.el was indeed intended, then my
	guess is that it should’ve been complemented with the changes to
	all of the packages above to make them fit the newly imposed
	criteria for inclusion.

-- 
FSF associate member #7257

bug#16255: C-h p C-s games RET (package-show-package-list?) misses most of the games

[Stefan Monnier]

> 	To me, the failure of the recent development version to show the
> 	above seems like a regression, regardless of the particulars.

Oh, right, sorry.  I didn't realize that finder already used package.el
in 24.3 to display the packages.  Hmm...

> 	If the change made to package.el was indeed intended, then my
> 	guess is that it should’ve been complemented with the changes to
> 	all of the packages above to make them fit the newly imposed
> 	criteria for inclusion.

The change was more along the lines that there's no point showing those
packages in package.el because there's nothing the user can do with them
in terms of install/update/uninstall (by virtue of being built-in and
having no version number).

But indeed, I see now that package.el was also used by finder as a kind
of browser to get at the package's Commentary, in which case those
unversioned packages can still be useful.

Hmm....


        Stefan

bug#16255: C-h p C-s games RET (package-show-package-list?) misses most of the games

[Ivan Shmakov]

Version: 24.4

>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:

 >> To me, the failure of the recent development version to show the
 >> above seems like a regression, regardless of the particulars.

 > Oh, right, sorry.  I didn't realize that finder already used
 > package.el in 24.3 to display the packages.  Hmm...

	I no longer observe the issue (as of 2014-11-18 build,
	cb4f666ade76.)  Per my reading of the Git log, it was fixed
	(as Bug#16762) in the emacs-24 branch back this March:

commit 3e2377ce2f4eeb141ffbd000723c55813f78b08f
Author:     Dmitry Gutov <dgutov@yandex.ru>
AuthorDate: Tue Mar 25 00:38:06 2014 +0200
Commit:     Dmitry Gutov <dgutov@yandex.ru>
CommitDate: Tue Mar 25 00:38:06 2014 +0200

    Fix bug#16762
    
    * lisp/emacs-lisp/package.el (package--add-to-archive-contents):
    Include already installed and built-in packages in
    `package-archive-contents'.
    (package-install): Don't include already installed packages in the
    options on interactive invocation.

[…]

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A