all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] Improve success message from org-remove-file.
@ 2014-11-24 17:36 Karl Fogel
  2014-11-25  8:25 ` Nicolas Goaziou
  0 siblings, 1 reply; 7+ messages in thread
From: Karl Fogel @ 2014-11-24 17:36 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

The attached patch improves the interactive success message from
`org-remove-file'.  Comments / suggestions welcome, of course; I've
tried to follow http://orgmode.org/worg/org-contribute.html here.

Best,
-Karl


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch to improve accuracy of success message from org-remove-file. --]
[-- Type: text/x-diff, Size: 1419 bytes --]

From 846d66a15c73a336c110f5238307242f9192e8c3 Mon Sep 17 00:00:00 2001
From: Karl Fogel <kfogel@red-bean.com>
Date: Mon, 24 Nov 2014 11:32:42 -0600
Subject: [PATCH] org.el: Improve accuracy of message

* lisp/org.el (org-remove-file): Reword success message.

Before this change, when `org-remove-file' succeeded in removing a
file from `org-agenda-files', it would display this unduly alarming
message to the user: "Removed file: foo.org".  This made it seem as
though the file itself were removed from the filesystem, rather than
simply being delisted from `org-agenda-files'.

After this change, the message "Removed from Org Agenda list: foo.org"
is displayed instead, so the user will experience only the normal
level of panic involved in using Org Mode, not the increased panic
that results from thinking a file has been removed when it hasn't.
---
 lisp/org.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 38c5726..9372191 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -18465,7 +18465,7 @@ Optional argument FILE means use this file instead of the current."
 	(progn
 	  (org-store-new-agenda-file-list files)
 	  (org-install-agenda-files-menu)
-	  (message "Removed file: %s" afile))
+	  (message "Removed from Org Agenda list: %s" afile))
       (message "File was not in list: %s (not removed)" afile))))
 
 (defun org-file-menu-entry (file)
-- 
2.1.3


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-12-01 14:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-24 17:36 [PATCH] Improve success message from org-remove-file Karl Fogel
2014-11-25  8:25 ` Nicolas Goaziou
2014-11-25 16:12   ` Karl Fogel
2014-11-25 19:51     ` Achim Gratz
2014-11-25 19:57       ` Achim Gratz
2014-11-26 11:35     ` Nicolas Goaziou
2014-12-01 13:44       ` Bastien

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.