emacs-devel@gnu.org

emacs-devel@gnu.org

[Mallory furry]

[-- Attachment #1: Type: text/html, Size: 1836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 141 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: emacs-devel@gnu.org

[Lars Magne Ingebrigtsen]

"Eric S. Raymond" <esr@thyrsus.com> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org>:
>> esr@snark.thyrsus.com (Eric S. Raymond) writes:
>> 
>> > I just restored vc-bzr-state-heuristic.  Confirm tht this unbreaks things?
>> 
>> I does; thanks.
>
> Now I need to try to figure out (a) why removing it broke things, and 
> (b) why it disn't break anything where I coulse see it.  That is concerning.

It's because `(vc-bzr-file-name-relative "~/rmz.jpg")' returns nil for
me.  What does it say for you?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: emacs-devel@gnu.org

[Eric S. Raymond]

Lars Magne Ingebrigtsen <larsi@gnus.org>:
> > Now I need to try to figure out (a) why removing it broke things, and 
> > (b) why it disn't break anything where I coulse see it.  That is concerning.
> 
> It's because `(vc-bzr-file-name-relative "~/rmz.jpg")' returns nil for
> me.  What does it say for you?

Same; nil.
-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>

Re: emacs-devel@gnu.org

[Lars Magne Ingebrigtsen]

"Eric S. Raymond" <esr@thyrsus.com> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org>:
>> > Now I need to try to figure out (a) why removing it broke things, and 
>> > (b) why it disn't break anything where I coulse see it.  That is concerning.
>> 
>> It's because `(vc-bzr-file-name-relative "~/rmz.jpg")' returns nil for
>> me.  What does it say for you?
>
> Same; nil.

Well, looking at the code, `vc-bzr-state' calls `vc-bzr-status' first,
which does `(regexp-quote (vc-bzr-file-name-relative file))', and if
that function returns nil for you, then `regexp-quote' should signal an
error, since that's not a valid input.

So `(vc-bzr-state file)' should signal an error for you.  :-)

Unless I'm totally misreading the code, which is, of course, possible.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: emacs-devel@gnu.org

[David Kastrup]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> "Eric S. Raymond" <esr@thyrsus.com> writes:
>
>> Lars Magne Ingebrigtsen <larsi@gnus.org>:
>>> > Now I need to try to figure out (a) why removing it broke things, and 
>>> > (b) why it disn't break anything where I coulse see it.  That is concerning.
>>> 
>>> It's because `(vc-bzr-file-name-relative "~/rmz.jpg")' returns nil for
>>> me.  What does it say for you?
>>
>> Same; nil.
>
> Well, looking at the code, `vc-bzr-state' calls `vc-bzr-status' first,
> which does `(regexp-quote (vc-bzr-file-name-relative file))', and if
> that function returns nil for you, then `regexp-quote' should signal an
> error, since that's not a valid input.
>
> So `(vc-bzr-state file)' should signal an error for you.  :-)
>
> Unless I'm totally misreading the code, which is, of course, possible.

Or he has everything under Git anyway so that his Emacs does not bother
checking for other version control system.

-- 
David Kastrup

Re: emacs-devel@gnu.org

[Andreas Schwab]

David Kastrup <dak@gnu.org> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
>> "Eric S. Raymond" <esr@thyrsus.com> writes:
>>
>>> Lars Magne Ingebrigtsen <larsi@gnus.org>:
>>>> > Now I need to try to figure out (a) why removing it broke things, and 
>>>> > (b) why it disn't break anything where I coulse see it.  That is concerning.
>>>> 
>>>> It's because `(vc-bzr-file-name-relative "~/rmz.jpg")' returns nil for
>>>> me.  What does it say for you?
>>>
>>> Same; nil.
>>
>> Well, looking at the code, `vc-bzr-state' calls `vc-bzr-status' first,
>> which does `(regexp-quote (vc-bzr-file-name-relative file))', and if
>> that function returns nil for you, then `regexp-quote' should signal an
>> error, since that's not a valid input.
>>
>> So `(vc-bzr-state file)' should signal an error for you.  :-)
>>
>> Unless I'm totally misreading the code, which is, of course, possible.
>
> Or he has everything under Git anyway so that his Emacs does not bother
> checking for other version control system.

vc-handled-backends has Bzr listed before Git.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

vc-bzr-state

[Ivan Shmakov]

>>>>> Andreas Schwab <schwab@linux-m68k.org> writes:

[…]

 >>> So `(vc-bzr-state file)' should signal an error for you.  :-)

 >>> Unless I'm totally misreading the code, which is, of course,
 >>> possible.

 >> Or he has everything under Git anyway so that his Emacs does not
 >> bother checking for other version control system.

	This should in no way change the behavior of an explicit call to
	a backend function, such as vc-bzr-state.

 > vc-handled-backends has Bzr listed before Git.

	Unless set otherwise.

vc-handled-backends
(Git MW CVS SVN SCCS Bzr Hg Arch RCS)

-- 
FSF associate member #7257  http://boycottsystemd.org/  … 3013 B6A0 230E 334A