all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Engster <deng@randomsample.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master c6f03ed: Fix a problem in url.el without GnuTLS
Date: Sun, 14 Dec 2014 22:40:41 +0100	[thread overview]
Message-ID: <87vbldoqp2.fsf@engster.org> (raw)
In-Reply-To: <83iohe43hu.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Dec 2014 18:09:49 +0200")

Eli Zaretskii writes:
> So this means that:
>
>   . Using "pull --rebase=preserve" always rewrites the merge to come
>     from some unnamed branch, which is different from the branch that
>     originated the merged commits.

Yes.

>   . This is true for merges from local branches as well.  Therefore,
>     using this option is not advisable for local branches, because
>     doing that would mean trouble when I next merge from master into
>     my local branch -- I will get the same commits back again.

Do you mean you have a long-living local branch which you regularly
merge to master? You're right that in this case doing 'pull
--rebase=preserve' is problematic. If you continue to work on your
branch and merge from master, you will indeed merge the rebased
commits. To avoid that, you would have to delete the old branch and
continue working on the rebased one.

>   . IOW, rebase=preserve is not useful in a merge-based workflow.

Rebasing is the anti-thesis to merging, so a purely merge-based workflow
wouldn't touch it in the first place (see: Bazaar).

> If it is, then here's my conundrum.  When I make changes in master, I
> don't want them to look as if they were made on some branch when I
> push them. Why? for starters, because "log --first-parent" won't show
> them.  So I use "pull --rebase" to avoid that.  This works well as
> long as I didn't make any local merge-commits, be it from my local
> branches or from public branches such as emacs-24.

Isn't flattening of the history precisely what you want when you have
merges of local branches, so that they appear like they were made on
master?

> AFAIU, an alternative, when I have local merge-commits, is to use
> "pull --ff-only", and when it refuses to pull, use "reset --hard
> origin/master", and then "merge -no-ff" and commit, before pushing.

That would also mean you have to fix conflicts again (unless you use the
'rerere' feature, but let's not go there yet).

> Which means there's no easy way with Git to support a workflow that
> preserves mainline, without jumping through some hoops.
>
> Is that correct?

I would say it is. AFAIK, Git has no notion of 'mainline' like Bazaar
had, so trying to preserve it does require a lot of discipline.

> If there is no better workflow, perhaps we need to radically rethink
> our recommended project workflow, like not base it on merges but on
> rebase, or push fixes to master and then cherry-pick them to the
> release branch, or something else.

Cherry-picking to emacs-24 would indeed make some things easier. Most
importantly, it would make gitmerge.el obsolete (which I consider a good
thing).

-David



  parent reply	other threads:[~2014-12-14 21:40 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20141211155740.11916.1584@vcs.savannah.gnu.org>
     [not found] ` <E1Xz67Y-00036o-Vf@vcs.savannah.gnu.org>
2014-12-11 16:47   ` master c6f03ed: Fix a problem in url.el without GnuTLS Leo Liu
2014-12-11 18:08     ` Eli Zaretskii
2014-12-11 23:00       ` Ted Zlatanov
2014-12-12  9:23         ` Eli Zaretskii
2014-12-12 13:24           ` Ted Zlatanov
2014-12-12 14:28             ` Eli Zaretskii
2014-12-12 16:06               ` Stefan Monnier
2014-12-13  0:25               ` Ted Zlatanov
2014-12-13  0:28                 ` Lars Magne Ingebrigtsen
2014-12-13  1:25                 ` Ted Zlatanov
2014-12-13  8:04                 ` Eli Zaretskii
2014-12-13 10:16                   ` David Engster
2014-12-18 22:38                     ` David Engster
2014-12-19  8:50                       ` Eli Zaretskii
2014-12-13  9:04                 ` David Engster
2014-12-13  9:50                   ` David Engster
2014-12-13 13:19                     ` Ted Zlatanov
2014-12-13 14:13                       ` David Engster
2014-12-13 14:25                         ` Ted Zlatanov
2014-12-13 15:18                         ` Eli Zaretskii
2014-12-13 19:44                           ` David Engster
2014-12-13 19:59                             ` Eli Zaretskii
2014-12-13 22:00                               ` Dmitry Gutov
2014-12-14  3:36                                 ` Eli Zaretskii
2014-12-13 23:13                               ` David Engster
2014-12-14 16:09                                 ` Eli Zaretskii
2014-12-14 16:37                                   ` Ted Zlatanov
2014-12-14 16:55                                     ` Eli Zaretskii
2014-12-14 17:00                                       ` Ted Zlatanov
2014-12-14 23:21                                     ` Stefan Monnier
2014-12-14 17:46                                   ` Paul Eggert
2014-12-14 17:50                                     ` Eli Zaretskii
2014-12-14 18:28                                     ` Ted Zlatanov
2014-12-14 19:41                                       ` David Engster
2014-12-14 21:40                                   ` David Engster [this message]
2014-12-15  3:47                                     ` Eli Zaretskii
2014-12-15 20:39                                       ` David Engster
2014-12-16 19:42                                         ` Eli Zaretskii
2014-12-17  9:58                                           ` Steinar Bang
2014-12-17 10:52                                             ` Steinar Bang
2014-12-17 15:36                                               ` Eli Zaretskii
2014-12-17 15:35                                             ` Eli Zaretskii
2014-12-17 20:37                                           ` David Engster
2014-12-18  4:55                                             ` Stephen J. Turnbull
2014-12-18 15:39                                               ` Eli Zaretskii
2014-12-18 20:00                                                 ` Steinar Bang
2014-12-18 20:40                                                   ` Eli Zaretskii
2014-12-19  8:09                                                     ` Steinar Bang
2014-12-19  9:16                                                       ` Eli Zaretskii
2014-12-19 10:33                                                         ` Steinar Bang
2014-12-18 21:18                                               ` David Engster
2014-12-18 15:38                                             ` Eli Zaretskii
2014-12-18 19:46                                               ` Steinar Bang
2014-12-18 20:35                                                 ` Eli Zaretskii
2014-12-19  6:07                                                   ` Yuri Khan
2014-12-19  7:57                                                     ` Steinar Bang
2014-12-19  9:09                                                     ` Eli Zaretskii
2014-12-18 20:46                                               ` David Engster
2014-12-14 22:42                                   ` Stefan Monnier
2014-12-15  3:37                                     ` Eli Zaretskii
2014-12-15  4:46                                       ` Stefan Monnier
2014-12-12 20:46             ` Lars Magne Ingebrigtsen
2014-12-12  0:30       ` Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbldoqp2.fsf@engster.org \
    --to=deng@randomsample.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.