From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [RFC] Display most recent log item in Agenda
Date: Mon, 15 Dec 2014 13:43:19 +0100 [thread overview]
Message-ID: <87vbld5biw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87ppbllmqj.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 15 Dec 2014 09:34:28 +0800")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> I started with this approach for two reasons: 1) I thought collecting
> the list items would be simpler, and as it became more and more
> complicated, I didn't rethink the approach, and 2) collecting all the
> items is the actual feature I was after (for future hackage), and the
> agenda display was just a nice bonus.
OK.
> I'd like to keep the collection routine (even just for myself, if it's
> not necessary for core), but you're right, the most-recent note display
> could be done differently.
Collecting is fine, but instead of using `org-log-beginning', I suggest
to factor out parts you need (e.g. find the log drawer, if any).
Note that if `org-log-into-drawer' is nil, you can only find all notes
heuristically (they might be scattered across the section). In this
case, finding the last note is safer.
>> Better, you could store the last note as a text property on the headline
>> and skip altogether the parsing phase.
>
> When would the storing happen? As the agenda was being built?
When the storing is done, i.e. after calling `org-store-log-note'.
However, you would need persistent data to save log notes across
sessions. So it isn't a good idea after all.
Regards,
next prev parent reply other threads:[~2014-12-15 12:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 10:07 [RFC] Display most recent log item in Agenda Eric Abrahamsen
2014-12-14 15:12 ` Eric Abrahamsen
2014-12-14 20:34 ` Nicolas Goaziou
2014-12-15 1:34 ` Eric Abrahamsen
2014-12-15 12:43 ` Nicolas Goaziou [this message]
2014-12-16 2:26 ` Eric Abrahamsen
2014-12-16 9:10 ` Nicolas Goaziou
2014-12-17 7:16 ` Eric Abrahamsen
2014-12-20 21:13 ` Nicolas Goaziou
2014-12-19 8:50 ` Eric Abrahamsen
2014-12-20 21:02 ` Nicolas Goaziou
2014-12-21 4:08 ` Eric Abrahamsen
2014-12-15 4:29 ` Eric Abrahamsen
2014-12-15 12:33 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbld5biw.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.