From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jon Snader <jsnader@mac.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch to implement sorting Org tables by IP address
Date: Sat, 20 Dec 2014 12:57:40 +0100 [thread overview]
Message-ID: <87vbl6zg7f.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <ABF84C2E-2C3A-4C5F-9FCF-582D3B551319@mac.com> (Jon Snader's message of "Wed, 17 Dec 2014 12:31:55 -0500")
Jon Snader <jsnader@mac.com> writes:
>> On Dec 14, 2014, at 12:18 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
>>> As I said above, you’ve convinced me that ?f ?F is the right solution.
>>
>> Fair enough. Let's settle on that, then.
>
> Here is the new patch. It extends org-table-sort-lines to allow a user
> to specify custom extraction and comparison functions using the ?f ?F
> sorting type as in org-sort-list.
>
> The user can call org-table-sort-lines programmatically specifying
> a SORTING-TYPE of ?f or ?F and provide custom extraction and
> comparison functions. If the user calls org-table-sort lines
> interactively and specifies ?f or ?F, org-do-sort will prompt for
> a custom extraction function. The comparison will be either string or
> numeric depending on the type of the first extracted key.
Thank you. Some comments follow.
> -any of (?a ?A ?n ?N ?t ?T) where the capital letter indicate that sorting
> -should be done in reverse order."
> +any of (?a ?A ?n ?N ?t ?T ?f ?F) where the capital letter indicate
> that sorting
"indicates" or "capital letters"
> + extractfun comparefun tempfun extract-string-p)
EXTRACT-STRING-P, and possibly TEMPFUN, are bound too early. See below.
> ;; Define the appropriate functions
> (cond
> ((= dcst ?n)
> @@ -9075,7 +9081,7 @@ If WITH-CASE is non-nil, the sorting will be case-sensitive."
> (setq extractfun (if with-case (lambda(x) (org-sort-remove-invisible x))
> (lambda(x) (downcase (org-sort-remove-invisible x))))
> comparefun (if (= dcst sorting-type)
> - 'string<
> + #'string<
OK, but then there are other occurrences in the function to modify.
I suggest to remove this.
> + ((= dcst ?f)
> + (setq tempfun (or getkey-func
> + (intern (org-icompleting-read
> + "Sort using function: "
> + obarray 'fboundp t nil nil))))
> + (setq extract-string-p (stringp (funcall tempfun (caar table))))
> + (setq extractfun (if (and extract-string-p (not with-case))
> + (lambda (x) (downcase (funcall tempfun x)))
> + tempfun))
> + (setq comparefun (or compare-func
> + (if extract-string-p
> + (if (= sorting-type ?f)
> + #'string<
> + (lambda (a b) (and (not (string< a b))
> + (not (string= a b)))))
> + (if (= sorting-type ?f)
> + #'<
> + #'>)))))
I suggest something like
(let* ((tempfun (or getkey-func
(intern ...)))
(extract-string-p (stringp (funcall tempfun (caar table)))))
(setq extractfun (if (and extract-string-p (not with-case))
`(lambda (x) (downcase (funcall ',tempfun x)))
tempfun))
(setq comparefun
(cond (compare-func)
(extract-string-p (if (= sorting-type ?f) #'string< #'org-string>))
((= sorting-type ?f) #'<)
(t #'>))))
Regards,
next prev parent reply other threads:[~2014-12-20 11:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 19:16 Patch to implement sorting Org tables by IP address Jon Snader
2014-12-12 22:58 ` Nicolas Goaziou
2014-12-13 14:19 ` Jon Snader
2014-12-13 14:29 ` Nicolas Goaziou
2014-12-13 15:19 ` Jon Snader
2014-12-13 16:01 ` Nicolas Goaziou
2014-12-13 18:47 ` Jon Snader
2014-12-13 22:07 ` Nicolas Goaziou
2014-12-13 22:37 ` Jon Snader
2014-12-14 11:25 ` Nicolas Goaziou
2014-12-14 15:19 ` Jon Snader
2014-12-14 17:18 ` Nicolas Goaziou
2014-12-17 17:31 ` Jon Snader
2014-12-20 11:57 ` Nicolas Goaziou [this message]
2014-12-20 18:40 ` Jon Snader
2014-12-20 20:55 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbl6zg7f.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=jsnader@mac.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.