From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] map 35c27cd: Throw an error when converting a map into an unknown map type Date: Sat, 18 Apr 2015 20:02:02 +0200 Message-ID: <87vbgtgvs5.fsf@petton.fr> References: <20150418143759.11954.68194@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1429380155 4047 80.91.229.3 (18 Apr 2015 18:02:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Apr 2015 18:02:35 +0000 (UTC) Cc: Nicolas Petton , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 18 20:02:24 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YjX4R-00024t-QJ for ged-emacs-devel@m.gmane.org; Sat, 18 Apr 2015 20:02:23 +0200 Original-Received: from localhost ([::1]:46465 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjX4R-0003gD-79 for ged-emacs-devel@m.gmane.org; Sat, 18 Apr 2015 14:02:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjX4E-0003fz-83 for emacs-devel@gnu.org; Sat, 18 Apr 2015 14:02:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YjX4B-0000nU-1q for emacs-devel@gnu.org; Sat, 18 Apr 2015 14:02:10 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjX4A-0000nJ-V8 for emacs-devel@gnu.org; Sat, 18 Apr 2015 14:02:06 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4C995208AF for ; Sat, 18 Apr 2015 14:02:06 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Sat, 18 Apr 2015 14:02:06 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=uPrcPFhno9hbslM/iEs3fPQVhSs=; b=tVKOI RAa38VjyLmR/QpUkZr1pOqg0hSgn6zbT9+jYW0aWGRgayzjwiAwQKAMd3q7+GgIE v2l8DQUGqUg/Hb0VK5R/5AVVoOnhBUuXAUnwB6Sn0f6Xn9TS8esI4qc7dxCZr/wb iBoeFjPAFwx+FBJLpgKXSM9Z5RUAXoqfPNJsxU= X-Sasl-enc: 7Bm6/48yh0CizEj0BcaN7CjDjGlmBk1FzOM1f4hX+NPT 1429380125 Original-Received: from blueberry (unknown [80.216.68.107]) by mail.messagingengine.com (Postfix) with ESMTPA id B339768019D; Sat, 18 Apr 2015 14:02:04 -0400 (EDT) In-reply-to: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.111.4.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185620 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Stefan Monnier writes: >> + (t (error "Not a map type name: %s" type)))) > ^^ > %S > > In case the user didn't pass the right argument `type' may be something > else than a symbol, so the use of %S makes sure that the error will give > a precise description (e.g. if `type' is the string "hash-table", the > error message could be surprising). Oh, thanks! The same is true in seq.el, I'll fix both of them :) Nico =2D-=20 Nicolas Petton http://nicolas-petton.fr --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: GPGTools - http://gpgtools.org iQEcBAEBAgAGBQJVMpwaAAoJECM1h6R8IHkQSQIH/1P7LDOtBbg7KNtUj+mvHj0x QO4C3/wDhxOXd6AeQqyWleodsn8bfAbT3hBIWV16x6+v2bi3jg15JRl0pifC+nck KM72PslEpDiNtGStKZ9v57Y6wmGRXYKaLser5EuN6zT79zFspZZGP6ShBSArJEkd 4gJEWJrS8JqwVZ9EdmqIH8zt/LXJf+TlDGZ+G6IZN58y/ranf7vTDz+/zwBgZBmw 3iaxZ69dzesgMWuX0IHrcDrUluC97OEI8O7AVHiJ8ORMMsahCXlQM9bAZ6ZUTEBM liHbjgwW9xB/VsGuYgxhEo301MZne3C6DkCGLfs+o29U7ssAZDVOmfamSUdrJkI= =Jehb -----END PGP SIGNATURE----- --=-=-=--