Re: [Emacs-diffs] map 35c27cd: Throw an error when converting a map into an unknown map type

Re: [Emacs-diffs] map 35c27cd: Throw an error when converting a map into an unknown map type

[Stefan Monnier]

> +    (t (error "Not a map type name: %s" type))))
                                       ^^
                                       %S

In case the user didn't pass the right argument `type' may be something
else than a symbol, so the use of %S makes sure that the error will give
a precise description (e.g. if `type' is the string "hash-table", the
error message could be surprising).


        Stefan

Re: [Emacs-diffs] map 35c27cd: Throw an error when converting a map into an unknown map type

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]


Stefan Monnier writes:

>> +    (t (error "Not a map type name: %s" type))))
>                                        ^^
>                                        %S
>
> In case the user didn't pass the right argument `type' may be something
> else than a symbol, so the use of %S makes sure that the error will give
> a precise description (e.g. if `type' is the string "hash-table", the
> error message could be surprising).

Oh, thanks! The same is true in seq.el, I'll fix both of them :)

Nico
-- 
Nicolas Petton
http://nicolas-petton.fr

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]