From: Nicolas Petton <nicolas@petton.fr>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Nicolas Petton <nicolas@petton.fr>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] map 35c27cd: Throw an error when converting a map into an unknown map type
Date: Sat, 18 Apr 2015 20:02:02 +0200 [thread overview]
Message-ID: <87vbgtgvs5.fsf@petton.fr> (raw)
In-Reply-To: <jwvfv7xs52q.fsf-monnier+emacsdiffs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
Stefan Monnier writes:
>> + (t (error "Not a map type name: %s" type))))
> ^^
> %S
>
> In case the user didn't pass the right argument `type' may be something
> else than a symbol, so the use of %S makes sure that the error will give
> a precise description (e.g. if `type' is the string "hash-table", the
> error message could be surprising).
Oh, thanks! The same is true in seq.el, I'll fix both of them :)
Nico
--
Nicolas Petton
http://nicolas-petton.fr
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
prev parent reply other threads:[~2015-04-18 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150418143759.11954.68194@vcs.savannah.gnu.org>
[not found] ` <E1YjTsd-00037Q-9M@vcs.savannah.gnu.org>
2015-04-18 17:47 ` [Emacs-diffs] map 35c27cd: Throw an error when converting a map into an unknown map type Stefan Monnier
2015-04-18 18:02 ` Nicolas Petton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbgtgvs5.fsf@petton.fr \
--to=nicolas@petton.fr \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.