all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Oleh Krehel <ohwoeowho@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Unclear org-icompleting-read interface
Date: Thu, 25 Jun 2015 15:15:59 +0200	[thread overview]
Message-ID: <87vbecudww.fsf@gmail.com> (raw)


Hi all,

The current `org-icompleting-read' is defined as taking only `&rest
args', which can be as many as 8, all of them without a name.

I propose to update the definition to:

    (cl-defun org-icompleting-read (prompt collection
                                    &key predicate require-match
                                      initial-input hist def inherit-input-method)
      ;; ...
      )

Let me know if you like the idea. If so, there are 43 calls to
`org-icompleting-read' in the source that need to be updated. Some of
them should as they are, since usually only the first two arguments are
used.

This change would make the calls to `org-icompleting-read' much easier
to read.

regards,
Oleh

             reply	other threads:[~2015-06-25 13:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 13:15 Oleh Krehel [this message]
2015-06-25 13:51 ` Unclear org-icompleting-read interface Nicolas Goaziou
2015-06-25 14:23   ` Oleh Krehel
2015-06-25 14:36   ` Rasmus
2015-06-25 16:30     ` Nicolas Goaziou
2015-06-25 16:39       ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbecudww.fsf@gmail.com \
    --to=ohwoeowho@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.