From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] fix/undo-point-in-wrong-place 6b3cfe4 4/4: Prepare for record now separate function. Date: Wed, 25 Nov 2015 22:46:59 +0000 Message-ID: <87vb8py9wc.fsf@russet.org.uk> References: <20151120221320.21643.45342@vcs.savannah.gnu.org> <87k2p8aa0n.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448492981 5027 80.91.229.3 (25 Nov 2015 23:09:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Nov 2015 23:09:41 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 26 00:09:32 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a1jBk-00042f-Ew for ged-emacs-devel@m.gmane.org; Thu, 26 Nov 2015 00:09:24 +0100 Original-Received: from localhost ([::1]:48189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1jBl-0000OU-Vj for ged-emacs-devel@m.gmane.org; Wed, 25 Nov 2015 18:09:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1jBj-0000OD-4G for emacs-devel@gnu.org; Wed, 25 Nov 2015 18:09:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1jBe-000408-2I for emacs-devel@gnu.org; Wed, 25 Nov 2015 18:09:23 -0500 Original-Received: from cheviot12.ncl.ac.uk ([128.240.234.12]:52519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1jBd-000400-SD for emacs-devel@gnu.org; Wed, 25 Nov 2015 18:09:17 -0500 Original-Received: from smtpauth-vm.ncl.ac.uk ([10.8.233.129] helo=smtpauth.ncl.ac.uk) by cheviot12.ncl.ac.uk with esmtp (Exim 4.63) (envelope-from ) id 1a1jBd-0007jC-9j; Wed, 25 Nov 2015 23:09:17 +0000 Original-Received: from cpc6-benw10-2-0-cust45.gate.cable.virginm.net ([92.238.179.46] helo=localhost) by smtpauth.ncl.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1a1jBc-0002Ri-Sn; Wed, 25 Nov 2015 23:09:16 +0000 In-Reply-To: <87k2p8aa0n.fsf@russet.org.uk> (Phillip Lord's message of "Mon, 23 Nov 2015 17:41:28 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.240.234.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195266 Archived-At: Phillip Lord writes: > Stefan Monnier writes: > >> So the hunk below should recover the old behavior (well, more or less: >> it wouldn't compile as is, but I hope you get the idea). But to fix it >> right, we should rename these vars and adjust their comment to better >> reflect the way they're really used. >> > > I've pushed an alternative solution (yes, I know I said I would just do > what you told me, but I could not resist). There is already > last_point_position and prev_buffer variables which do this, as far as I > can tell. Does this seem a reasonable solution (I've used the idea behind your patch, but with variables that already exist in keyboard.c)? Phil