all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: phillip.lord@russet.org.uk (Phillip Lord)
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] fix/undo-point-in-wrong-place 6b3cfe4 4/4: Prepare for record now separate function.
Date: Wed, 25 Nov 2015 22:46:59 +0000	[thread overview]
Message-ID: <87vb8py9wc.fsf@russet.org.uk> (raw)
In-Reply-To: <87k2p8aa0n.fsf@russet.org.uk> (Phillip Lord's message of "Mon, 23 Nov 2015 17:41:28 +0000")

Phillip Lord <phillip.lord@russet.org.uk> writes:

> Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>
>> So the hunk below should recover the old behavior (well, more or less:
>> it wouldn't compile as is, but I hope you get the idea).  But to fix it
>> right, we should rename these vars and adjust their comment to better
>> reflect the way they're really used.
>>
>
> I've pushed an alternative solution (yes, I know I said I would just do
> what you told me, but I could not resist). There is already
> last_point_position and prev_buffer variables which do this, as far as I
> can tell.

Does this seem a reasonable solution (I've used the idea behind your
patch, but with variables that already exist in keyboard.c)?

Phil



  reply	other threads:[~2015-11-25 22:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20151120221320.21643.45342@vcs.savannah.gnu.org>
     [not found] ` <E1Zztvo-0005ey-0X@vcs.savannah.gnu.org>
2015-11-22  5:21   ` [Emacs-diffs] fix/undo-point-in-wrong-place 6b3cfe4 4/4: Prepare for record now separate function Stefan Monnier
2015-11-23 17:41     ` Phillip Lord
2015-11-25 22:46       ` Phillip Lord [this message]
2015-11-26  4:00         ` Stefan Monnier
2015-11-26 10:32           ` Phillip Lord
2015-11-26 15:56             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb8py9wc.fsf@russet.org.uk \
    --to=phillip.lord@russet.org.uk \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.