From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#5650: Issue with the patch Date: Sun, 27 Dec 2015 23:17:23 +0100 Message-ID: <87vb7j5yfg.fsf@gnus.org> References: <87wry1x9k2.wl%richard.lewis@gold.ac.uk> <1272227954.9935.39.camel@kiwi-pc2> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451255553 27588 80.91.229.3 (27 Dec 2015 22:32:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Dec 2015 22:32:33 +0000 (UTC) Cc: 5650@debbugs.gnu.org To: Thomas Riccardi Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 27 23:32:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDJrL-00031v-KU for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2015 23:32:15 +0100 Original-Received: from localhost ([::1]:42963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDJrL-0000VP-1v for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2015 17:32:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDJrB-0000Mz-L5 for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 17:32:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDJr8-0001Gr-Eg for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 17:32:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDJr8-0001Gn-Ax for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 17:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aDJr8-0003vZ-6o for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 17:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2015 22:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5650 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 5650-submit@debbugs.gnu.org id=B5650.145125551615073 (code B ref 5650); Sun, 27 Dec 2015 22:32:02 +0000 Original-Received: (at 5650) by debbugs.gnu.org; 27 Dec 2015 22:31:56 +0000 Original-Received: from localhost ([127.0.0.1]:45079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDJr2-0003v3-6i for submit@debbugs.gnu.org; Sun, 27 Dec 2015 17:31:56 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:37697) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDJr0-0003uo-Sc for 5650@debbugs.gnu.org; Sun, 27 Dec 2015 17:31:55 -0500 Original-Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDJqa-0004iW-8D; Sun, 27 Dec 2015 23:31:28 +0100 In-Reply-To: <1272227954.9935.39.camel@kiwi-pc2> (Thomas Riccardi's message of "Sun, 25 Apr 2010 22:39:14 +0200") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aDJqa-0004iW-8D MailScanner-NULL-Check: 1451860288.52481@YItvZDOycOHPA88jT1NyAw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110867 Archived-At: Thomas Riccardi writes: > The patch works for me (even if there is still a small freeze during > about 1 second at the connection if the server doesn't answer), but > creates an issue with the auto reconnect feature. > > It happens when the server doesn't answer the connection request (tested > with a DROP on packets coming from it with iptables). > > The patch makes the function erc-server-connect to return even if the > connection is not ready. Then erc-open and erc-server-reconnect do the > same. > > Finally, in erc-process-sentinel-2, there is no error executing > erc-server-reconnect, thus erc-server-reconnect-count is never > incremented and is even reset. > > I made a patch that increments erc-server-reconnect-count before calling > erc-server-reconnect instead, and resets it only when the connection is > really ready, that is, in erc-connection-established. > Thanks; applied to the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no