all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22557-done@debbugs.gnu.org
Subject: bug#22557: 25.0.90; Saving a buffer under auto-revert turns off file notifications
Date: Sun, 07 Feb 2016 20:56:37 +0100	[thread overview]
Message-ID: <87vb60guq2.fsf@gmx.de> (raw)
In-Reply-To: <83wpqgqpfb.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 Feb 2016 21:40:56 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> I've committed a patch to the emacs-25 branch, which shall fix
>> this.
>
> It does, thanks.

So I'm closing the bug.

>> There is also a new test file-notify-test07-backup for this
>> problems. W/o the fix in filenotify.el, this test failed. Now it
>> succeeds for me.
>
> It fails for me on w32, I need 2 changed events, not one.  If this is
> surprising, I can investigate more.

As said, there are good chances that I'll have access to an MS Windows
machine next week; I'll run all tests there.

I have seen with inotify that I'll get a changed and then an
attribute-changed event; the attribute-changed event is suppressed in
the test.

On MS Windows, there are no attribute-changed events IIUC; they are sent
also as changed events. Therefore, you see two changed events. This is
also the case in other tests, see the comments in
file-notify-test02-events. I'll try to verify this, and adjust the
expected events for file-notify-test07-backup on MS Windows.

Best regards, Michael.





  reply	other threads:[~2016-02-07 19:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04 18:34 bug#22557: 25.0.90; Saving a buffer under auto-revert turns off file notifications Eli Zaretskii
2016-02-05 12:24 ` Michael Albinus
2016-02-05 14:41   ` Eli Zaretskii
2016-02-05 14:50     ` Michael Albinus
2016-02-07 18:35     ` Michael Albinus
2016-02-07 19:40       ` Eli Zaretskii
2016-02-07 19:56         ` Michael Albinus [this message]
2016-02-07 20:32           ` Eli Zaretskii
2016-02-08 10:02             ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb60guq2.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=22557-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.