From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Asynchronous DNS Date: Sun, 14 Feb 2016 13:20:21 +1100 Message-ID: <87vb5sdod6.fsf@gnus.org> References: <87vb63obm3.fsf@gnus.org> <87r3gqmg6g.fsf@gnus.org> <83egcqtfnm.fsf@gnu.org> <86mvrdmk8p.fsf@realize.ch> <877fihjo4m.fsf@gnus.org> <86io20n3xn.fsf@realize.ch> <8760y055l1.fsf@gnus.org> <8660xzmyyr.fsf@realize.ch> <87pow7ocyw.fsf@gnus.org> <861t8nmxlj.fsf@realize.ch> <87y4auiurw.fsf@gnus.org> <86k2me8dee.fsf@realize.ch> <83a8n9ddk5.fsf@gnu.org> <864mdh8vj5.fsf@realize.ch> <87pow579kt.fsf@gnus.org> <86ziv87st0.fsf@realize.ch> <87vb5u4qtq.fsf@gnus.org> <86egci6xvk.fsf@realize.ch> <87twldgsrv.fsf@gnus.org> <8637sw7w4m.fsf@realize.ch> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1455416479 16195 80.91.229.3 (14 Feb 2016 02:21:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Feb 2016 02:21:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alain Schneble Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 14 03:21:09 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aUmJA-0003K2-Rz for ged-emacs-devel@m.gmane.org; Sun, 14 Feb 2016 03:21:09 +0100 Original-Received: from localhost ([::1]:46590 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUmJ9-0001hj-Uy for ged-emacs-devel@m.gmane.org; Sat, 13 Feb 2016 21:21:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUmIw-0001ha-IV for emacs-devel@gnu.org; Sat, 13 Feb 2016 21:20:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aUmIs-0005oX-J9 for emacs-devel@gnu.org; Sat, 13 Feb 2016 21:20:54 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:57417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aUmIs-0005oT-Be for emacs-devel@gnu.org; Sat, 13 Feb 2016 21:20:50 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aUmIU-0000Tu-Aa; Sun, 14 Feb 2016 03:20:27 +0100 In-Reply-To: <8637sw7w4m.fsf@realize.ch> (Alain Schneble's message of "Sat, 13 Feb 2016 11:16:57 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aUmIU-0000Tu-Aa MailScanner-NULL-Check: 1456021228.78273@10UsMifUH4XkxJeCrCe0Tw X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199904 Archived-At: Alain Schneble writes: >> With :nowait t now, inch/outch will never be zero here, because we've > ^^^ > What do you mean by now? I was referring to the async DNS resolve case. > >> crated the sockets, even if we haven't connected them... So it seems >> like it'll complete whatever it's doing even if those sockets aren't >> connected. Possibly. > > That's true for the previous non-async DNS code. But with async DNS, > the socket may not yet have been created. Yeah, I was talking about the current (and async-dns) :nowait t code. The :nowait 'immediate code, of course, has other paths. If we just add blockers to these functions, then code that worked perfectly well with :nowait t now will stop working (as well). That's a regression we can't fix for out-of-tree usages of make-network-process, so I'm back to thinking that we should not change any of those functions, and :nowait t should work like it does today, and if you want make-network-process to return before the socket has been set up (i.e., :nowait 'immediate), then you have to wait until the process is in state 'run before calling those functions. I.e., I think we should merge async-dns into trunk as is. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no